-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Unit's numDepartments
prop not being updated after a department is removed
#34137
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 97e3508 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34137 +/- ##
========================================
Coverage 75.79% 75.79%
========================================
Files 511 511
Lines 22132 22132
Branches 5394 5394
========================================
Hits 16775 16775
Misses 4709 4709
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
apps/meteor/ee/app/livechat-enterprise/server/hooks/afterRemoveDepartment.ts
Outdated
Show resolved
Hide resolved
Do we also have a PR for the next major to fix this inconsistency on existing Units? |
Don't think it's needed. But if a customer ever complains about this (think us found this while working on another thing) then a new task may be needed. |
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-541
Steps to test or reproduce
Further comments
This is not a retroactive fix. Units with an already incorrect count will continue to have it. However, new units created after the fix won't have it anymore.