Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: AppsFilters text search freezing when typing #34051

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Nov 25, 2024

Proposed changes (including videos or screenshots)

Introduced here #33735

Issue(s)

CORE-835

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: b86022c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.1.0 milestone Nov 25, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34051/
on branch gh-pages at 2024-11-25 15:13 UTC

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (90aa786) to head (b86022c).
Report is 2 commits behind head on release-7.1.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.1.0   #34051   +/-   ##
==============================================
  Coverage          75.79%   75.79%           
==============================================
  Files                510      510           
  Lines              22063    22063           
  Branches            5385     5385           
==============================================
  Hits               16723    16723           
  Misses              4694     4694           
  Partials             646      646           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@dougfabris dougfabris marked this pull request as ready for review November 25, 2024 16:29
@dougfabris dougfabris requested a review from a team as a code owner November 25, 2024 16:29
tassoevan
tassoevan previously approved these changes Nov 25, 2024
@tassoevan tassoevan dismissed their stale review November 25, 2024 17:46

missing changeset

@dougfabris dougfabris changed the title regression: AppsFilters text searching freezing when typing regression: AppsFilters text search freezing when typing Nov 25, 2024
@tassoevan tassoevan merged commit 49b90eb into release-7.1.0 Nov 25, 2024
51 checks passed
@tassoevan tassoevan deleted the reg/marketplace-search branch November 25, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants