Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: Use visitor activity to define if its contact is unknown #33993

Merged
merged 3 commits into from
Nov 26, 2024
Merged

regression: Use visitor activity to define if its contact is unknown #33993

merged 3 commits into from
Nov 26, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Nov 19, 2024 •
edited by dougfabris
Loading

Proposed changes (including videos or screenshots)

Introduced here: #32727

  • Do not tag visitor contact as unknown if it has already been active

Issue(s)

Steps to test or reproduce

Further comments

SCI-163

@matheusbsilva137 matheusbsilva137 added this to the 7.1.0 milestone Nov 19, 2024
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 19, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 60195e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (ab1ebfb) to head (60195e8).
Report is 4 commits behind head on release-7.1.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.1.0   #33993   +/-   ##
==============================================
  Coverage          75.79%   75.79%           
==============================================
  Files                510      510           
  Lines              22063    22063           
  Branches            5385     5385           
==============================================
  Hits               16723    16723           
  Misses              4694     4694           
  Partials             646      646
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33993/
on branch gh-pages at 2024-11-25 18:10 UTC

Base automatically changed from feat/single-contact-id to develop November 19, 2024 19:30
@matheusbsilva137 matheusbsilva137 force-pushed the chore/visitor-activity-unknown-contact branch from 87fe337 to e08ad8f Compare November 19, 2024 22:37
@matheusbsilva137 matheusbsilva137 force-pushed the chore/visitor-activity-unknown-contact branch from e08ad8f to 0ec5eba Compare November 21, 2024 15:21
@matheusbsilva137 matheusbsilva137 changed the base branch from develop to release-7.1.0 November 21, 2024 15:21
@matheusbsilva137 matheusbsilva137 changed the title chore: Use visitor activity to define if its contact is unknown regression: Use visitor activity to define if its contact is unknown Nov 21, 2024
@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review November 21, 2024 15:22
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner November 21, 2024 15:22
@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label Nov 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 25, 2024
@kodiakhq kodiakhq bot merged commit e72e9d6 into release-7.1.0 Nov 26, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the chore/visitor-activity-unknown-contact branch November 26, 2024 13:46
ggazzo pushed a commit that referenced this pull request Dec 5, 2024
@matheusbsilva137 @ggazzo
regression: Use visitor activity to define if its contact is unknown (#…
2f7b59f 
…33993)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

@KevLehman KevLehman KevLehman approved these changes

@pierre-lehnen-rc pierre-lehnen-rc pierre-lehnen-rc left review comments

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@matheusbsilva137 @KevLehman @MarcosSpessatto @pierre-lehnen-rc