Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve indexes of the livechat contacts collection #33991

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 6471ee7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (8688bcd) to head (6471ee7).
Report is 15 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33991   +/-   ##
========================================
  Coverage    75.73%   75.73%           
========================================
  Files          507      507           
  Lines        21799    21799           
  Branches      5343     5343           
========================================
  Hits         16509    16509           
  Misses        4648     4648           
  Partials       642      642           
Flag Coverage Δ
unit 75.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Copy link
Contributor

github-actions bot commented Nov 19, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33991/
on branch gh-pages at 2024-11-19 20:14 UTC

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review November 19, 2024 13:43
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners November 19, 2024 13:43
KevLehman
KevLehman previously approved these changes Nov 19, 2024
Base automatically changed from feat/single-contact-id to develop November 19, 2024 19:30
@ggazzo ggazzo dismissed KevLehman’s stale review November 19, 2024 19:30

The base branch was changed.

@ggazzo ggazzo requested review from a team as code owners November 19, 2024 19:30
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Nov 19, 2024
@sampaiodiego sampaiodiego added this to the 7.1.0 milestone Nov 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 19, 2024
@ggazzo ggazzo merged commit f52d33d into develop Nov 20, 2024
51 checks passed
@ggazzo ggazzo deleted the chore/sci-indexes branch November 20, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants