Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clicking repeatedly on 'create' button result in multiple discusions created #33985

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Nov 18, 2024

Proposed changes (including videos or screenshots)

The discussion modal submit button isn't being blocked while submitting the form based on the mutation. This PR aims to add the loading prop to the button, based on the mutation loading state in order to prevent multiple clicks while submitting it

Issue(s)

CORE-607

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: 3b97197

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33985/
on branch gh-pages at 2024-11-19 19:38 UTC

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (c7bca10) to head (8f389c2).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33985   +/-   ##
========================================
  Coverage    75.73%   75.73%           
========================================
  Files          507      507           
  Lines        21799    21799           
  Branches      5343     5343           
========================================
  Hits         16509    16509           
  Misses        4648     4648           
  Partials       642      642           
Flag Coverage Δ
unit 75.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@dougfabris dougfabris added this to the 7.1.0 milestone Nov 19, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review November 19, 2024 17:33
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner November 19, 2024 17:33
apps/meteor/tests/e2e/message-actions.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/message-actions.spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Nov 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 19, 2024
@ggazzo ggazzo merged commit 2db1ecb into develop Nov 19, 2024
20 checks passed
@ggazzo ggazzo deleted the fix-disc branch November 19, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants