Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression(i18n): Broken translations in Setup Wizard #33777

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It fixes missing translations in Setup Wizard's forms.

Issue(s)

Steps to test or reproduce

Further comments

It wraps the <I18nextProvider /> element with the onboarding namespace only around @rocket.chat/onboarding-ui elements, leaving the useTranslation() calls outside still consuming the core namespace of translations.

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 0029b60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33777/
on branch gh-pages at 2024-10-24 22:47 UTC

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.55%. Comparing base (dd03d94) to head (0029b60).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33777   +/-   ##
========================================
  Coverage    75.55%   75.55%           
========================================
  Files          492      492           
  Lines        21558    21558           
  Branches      5373     5373           
========================================
  Hits         16288    16288           
  Misses        4630     4630           
  Partials       640      640           
Flag Coverage Δ
unit 75.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review October 24, 2024 23:36
@tassoevan tassoevan requested a review from a team as a code owner October 24, 2024 23:36
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 25, 2024
@ggazzo ggazzo added this to the 7.1.0 milestone Oct 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 25, 2024
@kodiakhq kodiakhq bot merged commit 899e0a6 into develop Oct 25, 2024
53 checks passed
@kodiakhq kodiakhq bot deleted the regression/setup-wizard-i18n branch October 25, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants