Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent loading page on reconnect #33770

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 24, 2024

https://rocketchat.atlassian.net/browse/CORE-761

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1309

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 2ec55cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33770/
on branch gh-pages at 2024-10-24 19:56 UTC

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.55%. Comparing base (72182ba) to head (2ec55cc).
Report is 16 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33770      +/-   ##
===========================================
- Coverage    75.56%   75.55%   -0.01%     
===========================================
  Files          491      492       +1     
  Lines        21533    21558      +25     
  Branches      5368     5373       +5     
===========================================
+ Hits         16271    16288      +17     
- Misses        4625     4630       +5     
- Partials       637      640       +3     
Flag Coverage Δ
unit 75.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 7.0 milestone Oct 24, 2024
@ggazzo ggazzo marked this pull request as ready for review October 24, 2024 20:14
@ggazzo ggazzo force-pushed the fix/blink-disconnection branch from 711cc9a to 5682885 Compare October 24, 2024 21:46
@ggazzo ggazzo force-pushed the fix/blink-disconnection branch from 5682885 to f8e4a74 Compare October 24, 2024 22:02
sampaiodiego
sampaiodiego previously approved these changes Oct 24, 2024
tassoevan
tassoevan previously approved these changes Oct 25, 2024
jeanfbrito
jeanfbrito previously approved these changes Oct 25, 2024
@ggazzo ggazzo force-pushed the fix/blink-disconnection branch from 07a9739 to 0a31a88 Compare October 25, 2024 15:25
@ggazzo
Copy link
Member Author

ggazzo commented Oct 25, 2024

image

jeanfbrito
jeanfbrito previously approved these changes Oct 25, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 25, 2024
@ggazzo ggazzo merged commit 0cc3208 into develop Oct 25, 2024
8 of 9 checks passed
@ggazzo ggazzo deleted the fix/blink-disconnection branch October 25, 2024 16:32
ggazzo added a commit that referenced this pull request Oct 25, 2024
ggazzo added a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants