Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky should mark target default channel as "favorite by default" test #33769

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Oct 24, 2024

Proposed changes (including videos or screenshots)

image
Sometimes when the room information was closing, the tests tried to open a new room information sidebar, but since the one before was closing, nothing happened. This adds an assertion to wait for the sidebar to be properly closed

Issue(s)

https://rocketchat.atlassian.net/browse/FLAKY-1090

@MartinSchoeler MartinSchoeler added this to the 7.1.0 milestone Oct 24, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: c16168c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33769/
on branch gh-pages at 2024-10-24 19:54 UTC

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.55%. Comparing base (0cc3208) to head (c16168c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33769   +/-   ##
========================================
  Coverage    75.55%   75.55%           
========================================
  Files          492      492           
  Lines        21558    21558           
  Branches      5373     5373           
========================================
  Hits         16288    16288           
  Misses        4630     4630           
  Partials       640      640           
Flag Coverage Δ
unit 75.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review October 25, 2024 13:37
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner October 25, 2024 13:37
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Oct 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 25, 2024
@ggazzo ggazzo merged commit e04a112 into develop Oct 25, 2024
21 checks passed
@ggazzo ggazzo deleted the fix-flaky-favorite branch October 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants