-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove proxifyWithWait
and waitAndCall
#33710
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
cb23555
to
10569fa
Compare
10569fa
to
5ccebc9
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33710 +/- ##
===========================================
+ Coverage 74.97% 75.01% +0.04%
===========================================
Files 480 480
Lines 21020 21000 -20
Branches 5335 5329 -6
===========================================
- Hits 15759 15754 -5
+ Misses 4632 4619 -13
+ Partials 629 627 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
The usage of
proxifyWithWait
was not as good as intended. The idea was to add a delay in case a service was not yet initialized, but in fact this should by accomplished by adding a dependency between services, just like every service depends on thelicense
service, so a service won't be initiated before the other one is there.In case a service was not spun up at all adding a 10s delay had no effect since the call would fail nonetheless.
Issue(s)
Steps to test or reproduce
Further comments