Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove proxifyWithWait and waitAndCall #33710

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Oct 22, 2024

Proposed changes (including videos or screenshots)

The usage of proxifyWithWait was not as good as intended. The idea was to add a delay in case a service was not yet initialized, but in fact this should by accomplished by adding a dependency between services, just like every service depends on the license service, so a service won't be initiated before the other one is there.

In case a service was not spun up at all adding a 10s delay had no effect since the call would fail nonetheless.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 22, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.1.0, but it targets 7.0.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 5ccebc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego force-pushed the chore-remove-proxify-with-wait branch from cb23555 to 10569fa Compare October 22, 2024 18:54
@sampaiodiego sampaiodiego force-pushed the chore-remove-proxify-with-wait branch from 10569fa to 5ccebc9 Compare October 22, 2024 19:15
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33710/
on branch gh-pages at 2024-10-22 19:20 UTC

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.01%. Comparing base (fd5e54f) to head (5ccebc9).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33710      +/-   ##
===========================================
+ Coverage    74.97%   75.01%   +0.04%     
===========================================
  Files          480      480              
  Lines        21020    21000      -20     
  Branches      5335     5329       -6     
===========================================
- Hits         15759    15754       -5     
+ Misses        4632     4619      -13     
+ Partials       629      627       -2     
Flag Coverage Δ
unit 75.01% <95.23%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego added this to the 7.1.0 milestone Oct 22, 2024
@sampaiodiego sampaiodiego marked this pull request as ready for review October 22, 2024 19:59
@sampaiodiego sampaiodiego requested a review from a team as a code owner October 22, 2024 19:59
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 22, 2024
@ggazzo ggazzo merged commit 2aaf64d into develop Oct 22, 2024
54 checks passed
@ggazzo ggazzo deleted the chore-remove-proxify-with-wait branch October 22, 2024 21:00
ggazzo pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants