Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: room with hideUnreadStatus showing on unread list #33704

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Oct 22, 2024

SIDE-222

Proposed changes (including videos or screenshots)

  • add missing hideUnreadStatus

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 22, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: a2fcbf1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33704/
on branch gh-pages at 2024-10-22 13:30 UTC

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (d69be40) to head (a2fcbf1).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33704   +/-   ##
========================================
  Coverage    74.97%   74.97%           
========================================
  Files          480      480           
  Lines        21020    21020           
  Branches      5335     5335           
========================================
  Hits         15759    15759           
  Misses        4632     4632           
  Partials       629      629           
Flag Coverage Δ
unit 74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review October 22, 2024 14:19
@juliajforesti juliajforesti requested a review from a team as a code owner October 22, 2024 14:19
@juliajforesti juliajforesti changed the title regression: rom with hideUnreadStatus showing on unread list regression: room with hideUnreadStatus showing on unread list Oct 22, 2024
@juliajforesti juliajforesti added this to the 7.0 milestone Oct 22, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 23, 2024
@ggazzo ggazzo merged commit b8e585a into develop Oct 23, 2024
56 checks passed
@ggazzo ggazzo deleted the regression/unread branch October 23, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants