-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: fix Sidebar collapsers keyboard navigation #33697
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33697 +/- ##
========================================
Coverage 75.01% 75.01%
========================================
Files 480 480
Lines 21000 21000
Branches 5329 5329
========================================
Hits 15754 15754
Misses 4619 4619
Partials 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. |
d7bf7e5
to
0996964
Compare
0996964
to
6b01c17
Compare
SIDE-217
Proposed changes (including videos or screenshots)
Enter
andSpace
) tohandleKeyDown
on groups collapserisCollapseGroup
touseSidebarListNavigation
Issue(s)
Steps to test or reproduce
Further comments