Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: fix Sidebar collapsers keyboard navigation #33697

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Oct 21, 2024

SIDE-217

Proposed changes (including videos or screenshots)

  • add keys (Enter and Space) to handleKeyDown on groups collapser
  • add verifier isCollapseGroup to useSidebarListNavigation

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 21, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 5a08abb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 21, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33697/
on branch gh-pages at 2024-10-22 13:57 UTC

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (2aaf64d) to head (5a08abb).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33697   +/-   ##
========================================
  Coverage    75.01%   75.01%           
========================================
  Files          480      480           
  Lines        21000    21000           
  Branches      5329     5329           
========================================
  Hits         15754    15754           
  Misses        4619     4619           
  Partials       627      627           
Flag Coverage Δ
unit 75.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti force-pushed the regression/collapser-on-keydown branch from d7bf7e5 to 0996964 Compare October 21, 2024 21:08
@juliajforesti juliajforesti marked this pull request as ready for review October 22, 2024 13:12
@juliajforesti juliajforesti requested a review from a team as a code owner October 22, 2024 13:12
@juliajforesti juliajforesti force-pushed the regression/collapser-on-keydown branch from 0996964 to 6b01c17 Compare October 22, 2024 13:49
@juliajforesti juliajforesti requested a review from ggazzo October 22, 2024 15:08
@juliajforesti juliajforesti added this to the 7.0 milestone Oct 22, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 22, 2024
@ggazzo ggazzo merged commit 12a2614 into develop Oct 23, 2024
40 of 42 checks passed
@ggazzo ggazzo deleted the regression/collapser-on-keydown branch October 23, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants