Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add withErrorBoundary to BannerRegion #33689

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix: add withErrorBoundary to BannerRegion #33689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90f1b79
fix: add `withErrorBoundary` to `BannerRegion`
MartinSchoeler Oct 21, 2024
ed27bf9
Create real-jeans-worry.md
MartinSchoeler Oct 21, 2024
b173fb2
Merge branch 'develop' into banner-break
kodiakhq[bot] Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/real-jeans-worry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixes banner breaking the UI with specific payloads
3 changes: 2 additions & 1 deletion apps/meteor/client/views/banners/BannerRegion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { ReactElement } from 'react';
import React from 'react';
import { useSyncExternalStore } from 'use-sync-external-store/shim';

import { withErrorBoundary } from '../../components/withErrorBoundary';
import * as banners from '../../lib/banners';
import LegacyBanner from './LegacyBanner';
import UiKitBanner from './UiKitBanner';
Expand All @@ -23,4 +24,4 @@ const BannerRegion = (): ReactElement | null => {
return <UiKitBanner key={payload.viewId} initialView={payload} />;
};

export default BannerRegion;
export default withErrorBoundary(BannerRegion);
Loading