Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace some cursor.count calls with countDocuments or estimatedDocumentCount #33671

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Oct 18, 2024

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-747

Steps to test or reproduce

Further comments

Replaces deprecated cursor.count calls with updated countDocuments or estimatedDocumentCount, for full table counts.

Copy link
Contributor

dionisio-bot bot commented Oct 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.1.0, but it targets 7.0.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: f68ffdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman added this to the 7.1.0 milestone Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33671/
on branch gh-pages at 2024-10-21 16:12 UTC

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.97%. Comparing base (5fddfcc) to head (f68ffdf).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33671      +/-   ##
===========================================
- Coverage    74.97%   74.97%   -0.01%     
===========================================
  Files          480      480              
  Lines        21019    21021       +2     
  Branches      5334     5335       +1     
===========================================
  Hits         15760    15760              
- Misses        4630     4632       +2     
  Partials       629      629              
Flag Coverage Δ
unit 74.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Oct 21, 2024
@KevLehman KevLehman marked this pull request as ready for review October 21, 2024 13:31
@KevLehman KevLehman requested a review from a team as a code owner October 21, 2024 13:31
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 21, 2024
@KevLehman KevLehman requested a review from a team as a code owner October 21, 2024 13:31
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so sad this could not land on release candidate

@kodiakhq kodiakhq bot merged commit 70f5730 into develop Oct 21, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the chore/remove-cursor.count-1 branch October 21, 2024 16:40
ricardogarim pushed a commit that referenced this pull request Oct 22, 2024
tassoevan pushed a commit that referenced this pull request Oct 23, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
ricardogarim pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants