-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace some cursor.count
calls with countDocuments
or estimatedDocumentCount
#33671
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33671 +/- ##
===========================================
- Coverage 74.97% 74.97% -0.01%
===========================================
Files 480 480
Lines 21019 21021 +2
Branches 5334 5335 +1
===========================================
Hits 15760 15760
- Misses 4630 4632 +2
Partials 629 629
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so sad this could not land on release candidate
…timatedDocumentCount` (#33671)
…timatedDocumentCount` (#33671)
…timatedDocumentCount` (#33671)
…timatedDocumentCount` (#33671)
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-747
Steps to test or reproduce
Further comments
Replaces deprecated
cursor.count
calls with updatedcountDocuments
orestimatedDocumentCount
, for full table counts.