Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Break big LivechatTyped file into smaller modules #33656

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Oct 18, 2024

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-751

Steps to test or reproduce

Further comments

No changes to functions were made, just from where they're imported, that's why you see 18 changes.
Any bug that was there, will be there

Copy link
Contributor

dionisio-bot bot commented Oct 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.1.0, but it targets 7.0.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 8a3671f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33656/
on branch gh-pages at 2024-10-22 13:05 UTC

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (d69be40) to head (8a3671f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33656   +/-   ##
========================================
  Coverage    74.97%   74.97%           
========================================
  Files          480      480           
  Lines        21020    21020           
  Branches      5335     5335           
========================================
  Hits         15759    15759           
  Misses        4632     4632           
  Partials       629      629           
Flag Coverage Δ
unit 74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@pierre-lehnen-rc pierre-lehnen-rc added this to the 7.1.0 milestone Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@KevLehman KevLehman removed the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@KevLehman KevLehman marked this pull request as ready for review October 21, 2024 20:45
@KevLehman KevLehman requested review from a team as code owners October 21, 2024 20:45
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Oct 22, 2024
@kodiakhq kodiakhq bot merged commit fd5e54f into develop Oct 22, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the chore/livechat-break-big branch October 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants