-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Break big LivechatTyped file into smaller modules #33656
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33656 +/- ##
========================================
Coverage 74.97% 74.97%
========================================
Files 480 480
Lines 21020 21020
Branches 5335 5335
========================================
Hits 15759 15759
Misses 4632 4632
Partials 629 629
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-751
Steps to test or reproduce
Further comments
No changes to functions were made, just from where they're imported, that's why you see 18 changes.
Any bug that was there, will be there