Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RocketChat/Rocket.Chat#329. Check for duplicate name before creating Channel and Private Group. Also, check Private Group for illegal name. #330

Merged
merged 2 commits into from
Jul 24, 2015

Conversation

rwakida
Copy link
Contributor

@rwakida rwakida commented Jul 23, 2015

channel or private group

Queried ChatRoom for Room with same name and returned a descriptive
error if one was found when creating a Channel or Private Group.

channel or private group

Queried ChatRoom for Room with same name and returned a descriptive
error if one was found when creating a Channel or Private Group.
@sampaiodiego
Copy link
Member

hey @rwakida , thanks for PR

the throwed messages are displayed to user? if so, can you change it for translations? like this

@rwakida
Copy link
Contributor Author

rwakida commented Jul 23, 2015

Hi @sampaiodiego, sorry, I forgot about internationalizing it. =)

I'll add it to the en.il8n.json, but what about the other languages? Do I add it in English so it's not forgotten?

@sampaiodiego
Copy link
Member

Exactly. Do it only for english, other languages will be translated later
on lingohub, it alerts about new words to be translated :)

Em qui, 23 de jul de 2015 16:26, Reid Wakida [email protected]
escreveu:

Hi @sampaiodiego https://github.com/sampaiodiego, sorry, I forgot about
internationalizing it. =)

I'll add it to the en.il8n.json, but what about the other languages? Do I
add it in English so it's not forgotten?


Reply to this email directly or view it on GitHub
#330 (comment)
.

.Diego Sampaio

private group and channel.  Check for illegal name for private group.

- Use il8n for error messages
- Add il8n english error message for duplicate channel/private group
  name
- Add illegal name serverside check to createPrivateGroup method
- Add logic to handle different error types on privateGroupsFlex page
@rwakida
Copy link
Contributor Author

rwakida commented Jul 24, 2015

HI @sampaiodiego. I updated the code to use il8n. Also, I realized that private groups didn't check for illegal names like channel does so I added the validation to createPrivateGroup.coffee.

@rwakida rwakida changed the title Fix RocketChat/Rocket.Chat#329. Check for duplicate name before creating Fix RocketChat/Rocket.Chat#329. Check for duplicate name before creating Channel and Private Group. Also, check Private Group for illegal name. Jul 24, 2015
@sampaiodiego sampaiodiego merged commit 3fe20c6 into RocketChat:master Jul 24, 2015
@sampaiodiego
Copy link
Member

well done @rwakida .. thank you again =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants