-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Update Image and link previews #27019
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipemarins
changed the title
[IMPROVE] Image previews
[IMPROVE] Image previews and link preview
Oct 17, 2022
filipemarins
force-pushed
the
update/oembed
branch
from
October 18, 2022 13:30
7e5431e
to
279fdae
Compare
ggazzo
approved these changes
Oct 19, 2022
gabriellsh
changed the title
[IMPROVE] Image previews and link preview
Chore: Update Image and link previews
Oct 19, 2022
Codecov Report
@@ Coverage Diff @@
## develop #27019 +/- ##
===========================================
+ Coverage 40.55% 41.19% +0.63%
===========================================
Files 827 803 -24
Lines 18250 17826 -424
Branches 2031 1972 -59
===========================================
- Hits 7402 7344 -58
+ Misses 10552 10184 -368
- Partials 296 298 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
MartinSchoeler
pushed a commit
that referenced
this pull request
Oct 25, 2022
Co-authored-by: Hugo Costa <[email protected]> Co-authored-by: gabriellsh <[email protected]>
Merged
Unfortunately I think this is the culprit for breaking the messageList views on Safari: #27172 The lookbehind used in line 60 of const normalizedUrl = imgURL.replace(/(?<!:)\/+/gm, '/'); |
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Hugo Costa <[email protected]> Co-authored-by: gabriellsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
og:image
and othersIssue(s)
closes #26838
TC-29 TC-95 TC-171
Steps to test or reproduce
Send links with previews to see the behavior of the messages.
Image URL preview:
Current Behavior
Images being cropped and not able to click to preview
Expected Behavior
Images with the original aspect ratio without cropping anything and it can be clicked to preview the image
--
URL preview:
Current Behavior
Expected Behavior
Further comments
It's necessary to sync with the fuselage pull request to see all changes if the PR was not merged
Fuselage Pull Request: RocketChat/fuselage#863