-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] starting conferences with mic and cam on their default states do not sync the state with the provider #26966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Sep 27, 2022
Codecov Report
@@ Coverage Diff @@
## develop #26966 +/- ##
===========================================
+ Coverage 40.46% 41.20% +0.74%
===========================================
Files 828 803 -25
Lines 18257 17826 -431
Branches 2031 1972 -59
===========================================
- Hits 7388 7346 -42
+ Misses 10575 10184 -391
- Partials 294 296 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
previously approved these changes
Sep 28, 2022
pierre-lehnen-rc
changed the title
Chore: Fix the option to start with camera off on VideoConf
[FIX] starting conferences with mic and cam on their default states do sync the state with the provider
Oct 5, 2022
pierre-lehnen-rc
changed the title
[FIX] starting conferences with mic and cam on their default states do sync the state with the provider
[FIX] starting conferences with mic and cam on their default states do not sync the state with the provider
Oct 6, 2022
gabriellsh
previously approved these changes
Oct 19, 2022
dougfabris
dismissed stale reviews from gabriellsh and pierre-lehnen-rc
via
October 20, 2022 18:29
0fcbc6a
ggazzo
approved these changes
Oct 21, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Oct 25, 2022
…o not sync the state with the provider (#26966)
gabriellsh
added a commit
that referenced
this pull request
Oct 31, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Unify isLastDocDelayed logic (#27120) [FIX] starting conferences with mic and cam on their default states do not sync the state with the provider (#26966) [NEW] Matrix federation events coverage expansion (adding support for 3 extra events) (#26859) Regression: Quote colors (#27110) Regression: Toolbox Divider Color (#27116)
Merged
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
…o not sync the state with the provider (#26966)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Task: VC-3
Issue(s)
Steps to test or reproduce
Further comments