[NEW] Add new endpoint 'livechat/room.saveInfo' & deprecate 'livechat:saveInfo' meteor method #26789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chat/room.saveInfo' endpoint
Codecov Report
@@ Coverage Diff @@
## develop #26789 +/- ##
===========================================
+ Coverage 41.09% 41.29% +0.20%
===========================================
Files 802 802
Lines 17819 17819
Branches 1972 1972
===========================================
+ Hits 7322 7358 +36
+ Misses 10200 10168 -32
+ Partials 297 293 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
previously requested changes
Sep 5, 2022
murtaza98
dismissed
KevLehman’s stale review
Changes done, Thanks for the suggestion guys :)
KevLehman
previously requested changes
Sep 14, 2022
murtaza98
force-pushed
the
chore/migrate-saveInfo
branch
from
209f53d to
3e915d1
Compare
sampaiodiego
previously approved these changes
Sep 19, 2022
murtaza98
dismissed
KevLehman’s stale review
Changes done! @kevin, Can you please check this one again ;)
KevLehman
previously approved these changes
Sep 20, 2022
murtaza98
dismissed stale reviews from KevLehman and sampaiodiego
via
983c380
KevLehman
previously approved these changes
Sep 23, 2022
sampaiodiego
previously approved these changes
Sep 23, 2022
|
should we flag PRs with new endpoints as |
murtaza98
changed the title
murtaza98
dismissed stale reviews from sampaiodiego and KevLehman
via
e84d575
KevLehman
approved these changes
Oct 17, 2022
|
Hi @sampaiodiego @MartinSchoeler Lost your approval here due to new commits. Do you mind checking this PR again and approving it if all looks good? 🤗 |
sampaiodiego
approved these changes
Oct 18, 2022
ggazzo
added
stat: ready to merge
|
Should we include this one on 5.3 since it's ready? |
|
|
MartinSchoeler
approved these changes
Oct 18, 2022
MartinSchoeler
pushed a commit
that referenced
this pull request
Oct 25, 2022
…:saveInfo' meteor method (#26789)
Merged
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
…:saveInfo' meteor method (#26789)
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
…:saveInfo' meteor method (#26789)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Jira: EOC-9 OC-358
PS: this also covers the issue fixed over here -> #26747