[FIX] Do not allow admin users edit other federated users #26528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## improve/federation-general-improvements #26528 +/- ##
========================================================================
Coverage 38.07% 38.07%
========================================================================
Files 745 745
Lines 18625 18625
Branches 1412 1412
========================================================================
Hits 7091 7091
+ Misses 11313 11310 -3
- Partials 221 224 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
alansikora
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
I haven't added tests for this endpoint change since we don't have a way to create a federated user (unless set up the whole federation) and simulate the behavior.