Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release Candidate Bug] Reset the layout colors make it transparent #8523

Closed
TheReal1604 opened this issue Oct 18, 2017 · 4 comments · Fixed by #8543 or #8544
Closed

[Release Candidate Bug] Reset the layout colors make it transparent #8523

TheReal1604 opened this issue Oct 18, 2017 · 4 comments · Fixed by #8543 or #8544
Milestone

Comments

@TheReal1604
Copy link
Contributor

Description:

Colors in the layout menu reset to "transparent" not to the default rocket.chat colors.
Found this after I upgraded my demo system to RC15.

Server Setup Information:

  • Version of Rocket.Chat Server: 0.59.0.rc15
  • Operating System: Ubuntu
  • Deployment Method(snap/docker/tar/etc): docker
  • Number of Running Instances: 3
  • DB Replicaset Oplog: yes

Steps to Reproduce:

  1. upgrade to 0.59.0.rc15
  2. try to reset my custom set colors in the layout admin interface
  3. it resets it to #FFFFFF but it is displayed transparent

Expected behavior:

The colors should reset to the default rocketchat colors.

Actual behavior:

It reset the color to transparent

@eloo
Copy link

eloo commented Oct 19, 2017

same in 0.59.0
edit:
it seems that the problem is that the reset will change the content of the text field to something like that -> color-dark but it does not change the dropdown to expression
and then it can't match the color-dark to and color (hex) and will fall back to the default #FFFFFF

@rodrigok
Copy link
Member

Version 0.59.1 https://github.com/RocketChat/Rocket.Chat/releases/tag/0.59.1 is building and will be available in a few minutes with fixes for LDAP and Color issues

@TheReal1604
Copy link
Contributor Author

@rodrigok you’re awesome!

@TheReal1604
Copy link
Contributor Author

TheReal1604 commented Oct 20, 2017

@rodrigok updated my systems to 0.59.1 and the color reset works fine now! Really thanks for the fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants