Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [UI] Background height is not equal for highlighted word #8385

Closed
cyclops24 opened this issue Oct 3, 2017 · 2 comments · Fixed by #8431
Closed

[BUG] [UI] Background height is not equal for highlighted word #8385

cyclops24 opened this issue Oct 3, 2017 · 2 comments · Fixed by #8431
Labels
type: improvement ui/ux
Milestone
0.59.3

Comments

@cyclops24
Copy link
Contributor

Hi,
When we use highlight word feature, background height is not equal for highlighted word:
26
@cyclops24
Copy link
Contributor Author

Part of #8175

@cyclops24
Copy link
Contributor Author

@karlprieb, @ggazzo I found issue but before create a PR to fix this I have one question?
Why we need this padding-top? I want remove this line to fix this issue.

Rocket.Chat/packages/rocketchat-theme/client/imports/general/base_old.css

Line 3231 in 76d2061

padding-top: 10px;

@cyclops24 cyclops24 mentioned this issue Oct 7, 2017
Merged
@rodrigok rodrigok added this to the 0.59.3 milestone Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: improvement ui/ux
Projects
None yet
Milestone
0.59.3
Development

Successfully merging a pull request may close this issue.

[FIX] Highlighted color height issue
3 participants
@rodrigok @cyclops24 @MartinSchoeler