Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating New DM Issue - Cannot search users by First Name for new Direct Messages since V 0.51.0 - still present up to current version 0.54.2 #6006

Closed
Nosferous opened this issue Feb 13, 2017 · 9 comments
Assignees
Milestone

Comments

@Nosferous
Copy link

Nosferous commented Feb 13, 2017

Issue introduced in Rocket.Chat Server Version 0.51.0
Issue still present up to current version release 0.54.2

Hosted on an Ubuntu 16.04 LTS

Behavior is the same in Browser and Electron App version 2.4.0 (which I would expect as this is a server code issue not electron app).

Creating Direct Messages is a pain now for my users. While we understand how the function works, it just doesn't work as well. Particularly searching for a user is clumsy and very specific. Before you could search either first, last name or username and accurate suggestions would pop-up immediately. Similar to how it does now when creating a private group channel and selecting Users. That still works OK. But direct messages- not really. It is so bad it has halted the rest of my deployment to the remaining departments at my company.

Current behavior with Direct Messages when you enter a first name I only get suggestions of people I've previously chatted with almost instantly. Otherwise I don't get a proper name of who I'm looking for unless I search for Last Name or Username. 95% of my user bases instinct is to search first name. They've already made a fuss about searching usernames before First/Last name searches were developed to work solidly in the add user fields before the recent server updates.

Our usernames are in the format of FLast (first initial last name). And the left side-bar interface is garbage when I search for a first name and it's trying to find a room, see screen: This is the same result whether I'm using a browser or Electron app.

Searching First Name Behavior current version (not working):
screen shot 2017-02-13 at 8 01 10 am
^ Note the searching for room notification is cutoff.

Searching Last Name behavior (working - same fine behavior when searching username ):
screen shot 2017-02-13 at 8 01 44 am

Searching First Name in the Private Groups select Users window (this is how direct messages used to prompt quick and painlessly and how we need direct messages to work again):
screen shot 2017-02-13 at 8 03 21 am

@Nosferous Nosferous changed the title Searching User for Direct Messages by First Name Issues V 0.51.0 Searching User for new Direct Messages by First Name Issues V 0.51.0 Feb 13, 2017
@engelgabriel engelgabriel added this to the 0.52.0 milestone Feb 13, 2017
@engelgabriel
Copy link
Member

Thanks for the detailed explanation. Indeed I believe the new search query ignored the first name. We are already planning to add the option to use the Full Name in all areas of the platform, and because that was not completed yet, we had this gap in functionality. I'll ask the team to add the Full name field back in the query.

@Nosferous
Copy link
Author

Thank you for the explanation.

I see the left bar "Room not found" text has been fixed in version 0.52.0 and is no longer cutoff and this issue is now adjusted to a version 0.53.0 milestone. Looking forward to the update for full name in the query in 0.53.0!

@engelgabriel engelgabriel modified the milestones: 0.54.0, 0.53.0 Mar 2, 2017
@Nosferous Nosferous changed the title Searching User for new Direct Messages by First Name Issues V 0.51.0 Searching User for new Direct Messages by First Name Issues V 0.51.0 - 0.53.0 Mar 6, 2017
@Nosferous
Copy link
Author

Nosferous commented Mar 6, 2017

@engelgabriel

What is the likeliness this one will be fixed in version 0.54.0?
Originally it was milestoned for 0.52.0

My deployment is still halted due to this 1 issue.

thanks!

@engelgabriel engelgabriel modified the milestones: 0.54.0, 0.55.0 Mar 22, 2017
@Nosferous Nosferous changed the title Searching User for new Direct Messages by First Name Issues V 0.51.0 - 0.53.0 Creating New DM Issue - Cannot search users by First Name for new Direct Messages since V 0.51.0 - still present up to current version 0.54.2 Mar 27, 2017
@localguru
Copy link
Contributor

localguru commented Mar 29, 2017

Yes please 👍 #6406

@engelgabriel
Copy link
Member

@MartinSchoeler can you test this on the develop branch?

@engelgabriel
Copy link
Member

Did #3851 closed this?

@alexbrazier
Copy link
Contributor

Yes, it now works on the latest version

@engelgabriel
Copy link
Member

Closed via #3851

@Nosferous
Copy link
Author

Confirmed that first name and full name searches are working again. Thank you for fixing this! I can now move forward with deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants