Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link previews of images in new message parser are cropped and can't be clicked to enlarge. #26838

Closed
chotaire opened this issue Sep 9, 2022 · 6 comments · Fixed by #27019
Closed

Comments

@chotaire
Copy link

chotaire commented Sep 9, 2022

Description:

Link previews of URLs to externally hosted images are often cropped and cannot be clicked to enlarge when using the new message parser.

Steps to reproduce:

  1. Post the following URL in a chat: https://i.gyazo.com/05c72da69a204f78f1008329cd5f5464.jpg
  2. See how the image is cropped (it seems to expect a 16:9 ratio)
  3. When hovering the mouse over the preview it shows how it is clickable, but nothing happens when clicked.

Expected behavior:

The behavior should be the same as with uploaded images. The image should be shown completely and when clicking it, it will open a full size view of the image.

Actual behavior:

Depending on the image (it seems to expect a 16:9 ratio), it is vertically cropped and clicking it does nothing.

Server Setup Information:

  • Version of Rocket.Chat Server: 5.1.1
  • Operating System: Linux
  • Deployment Method: Docker
  • Number of Running Instances: 1 on that server
  • DB Replicaset Oplog: Unknown
  • NodeJS Version: v14.19.3
  • MongoDB Version: 5.0.12 / wiredTiger (oplog Enabled)

Client Setup Information

  • Desktop App or Browser Version: Chrome Version 105.0.5195.102
  • Operating System: Windows 11 Pro (latest patches)

Screenshots

Legacy Message Parser (everything works):

7574c58fbd865d3ff7ba6ac9ed3e0cbb

New Message Parser (cropped and not clickable):

12d955e42c2e0b2ecc6b0d2fce38c610

New Message Parser when image has been uploaded (now it's clickable):

f66d1f40f6a45f5b8c38e201fa09e1a6

@ugzv
Copy link

ugzv commented Sep 10, 2022

I agree, it's annoying to see cropped images.

I don't like the way the images are now displayed after the 5.0.0 upgrade.

How can we show images in their natural size like it was before the update?

@chotaire
Copy link
Author

Not sure how it is with others, but this is the one issue that keeps me from enabling the new message parser in its current state because users really don't like it at all. It's not just cosmetic, not being able to click to enlarge is really very annoying.

@wreiske
Copy link
Contributor

wreiske commented Sep 14, 2022

#20546

@chotaire
Copy link
Author

chotaire commented Oct 3, 2022

#20546

That is a different issue (and it's even worse). The way it is handled right now: If not 16:9, the previews are just cropped, and they cannot be enlarged.

Still, this is the one issue that keeps me from switching the new message parser back on, and I will stick with the legacy parser until this has been worked on. This is the one issue that degrades the quality of Rocket.Chat so much after the update to 5.0 that I will not unleash this on my users. I see a lot of other issues have been taken care of, I also notice the number of closed issues within the past few weeks. But this one really deserves a lot more priority.

@hugocostadev
Copy link
Contributor

Hi @chotaire thank you for your feedback!

We are addressing a lot of Message Parser Issues, and this one Is being worked on by me in the current cycle.

You should expect a fix soon, once I have a Pull Request that fixes this issue I gonna mention this issue there.

Thanks

@chotaire
Copy link
Author

chotaire commented Oct 4, 2022

@hugocostadev Thanks for letting us know about the current status. It is much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants