Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] URL OEmbeds are cut off #20628

Closed
aditya-mitra opened this issue Feb 6, 2021 · 2 comments · Fixed by #20569
Closed

[BUG] URL OEmbeds are cut off #20628

aditya-mitra opened this issue Feb 6, 2021 · 2 comments · Fixed by #20569

Comments

@aditya-mitra
Copy link
Contributor

Description:

The og:description in the URL embeds are cutoff and not fully shown.

Steps to reproduce:

  1. Send a link to any channel (or direct message)
    Make sure the description of the link is long. Try https://95nyn.csb.app/ or https://github.com.
  2. You will find that the text is being wrapped and not fully shown

Expected behavior:

The full text is shown.

Actual behavior:

The text is being cutoff with ellipsis.

earlier

Server Setup Information:

  • Version of Rocket.Chat Server:
  • Operating System: Ubuntu
  • Deployment Method:
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: v12.18.4
  • MongoDB Version: 4.2.8 / wiredTiger (oplog Enabled)

Client Setup Information

  • Desktop App or Browser Version: Chrome/Firefox
  • Operating System: Ubuntu

Additional context

This is not related to issue #20556 because it is related to DefaultAttachments and not OEmbeds.

Relevant logs:

@ishansinghal9810
Copy link

If this issue is open I would love to help

@aditya-mitra
Copy link
Contributor Author

Thank you @ishansinghal9810 very much for trying to solve this issue.
But, you see there is already a pull request attached to this issue which would close it once merged.
However, you can always look for another issue.

Happy Hacking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants