Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing / wrong emoticon #2013

Closed
prohde opened this issue Jan 23, 2016 · 6 comments · Fixed by #4523
Closed

missing / wrong emoticon #2013

prohde opened this issue Jan 23, 2016 · 6 comments · Fixed by #4523

Comments

@prohde
Copy link

prohde commented Jan 23, 2016

Rocket.Chat (version 0.14.0) lists the emoticon mapped to :cry: also for :'( but after sending the message it remains :'(.
I would appreciate removing :'( from the list or mapping it to the listed emoticon.

@graywolf336
Copy link
Contributor

I vote for mapping it to the listed emoticon.

@prohde
Copy link
Author

prohde commented Jan 26, 2016

There are some other standard ones which are not even listed like ;)

@graywolf336
Copy link
Contributor

@prohde that one is mapped, I just tried it myself on the demo instance.

@prohde
Copy link
Author

prohde commented Jan 26, 2016

@graywolf336 Tried it on my own instance right now. It is mapped but there is no list showing this emoticon while writing.

@ada-lambrecht
Copy link

Confirmed, there is a mapping for :'( to sad but it is not being processed correctly. It looks like the root of the issue is that any emoji shortcut with a single quote is being html escaped. Once the single quote has been converted into ' it doesn't match the string in the emoji package.
Looks like it's actually 24 aliases that aren't working

:')
:'-)
':)
':-)
'=)
':D
':-D
'=D
>:)
>;)
>:-)
>=)
>:P
>:[
>:(
>:-(
>:\
>:/
>.<
>:O
:'(
:'-(
':(
':-(
'=(

I'm working on a PR for this.

@graywolf336
Copy link
Contributor

@barnardm How's the pull request coming along?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants