Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GraphQL Support #14959

Closed
engelgabriel opened this issue Jul 10, 2019 · 2 comments · Fixed by #15192
Closed

Remove GraphQL Support #14959

engelgabriel opened this issue Jul 10, 2019 · 2 comments · Fixed by #15192
Assignees
Milestone

Comments

@engelgabriel
Copy link
Member

The current implementation of our GraphQL API was an experiment that for many reasons did not get much adoption. It runs on a separate port and we were never able to fully integrate into the main code. For that reason, it has added too many dependencies that are useless for the vast majority of our deployments. It is the source of annoying issues like #10714 causing unnecessary load and worries.

We believe that supporting GraphQL is still on our long term plans, but we will have to refactor the implementation with the new architecture we are designing for high scalability.

With that in mind, we are planning to remove the current implementation from the code base and keep the PR #8158 as a reference for future development as an auxiliary Apolo base project (probably).

@winterstefan
Copy link
Contributor

Hey guys,

since I was send over from one of my pull requests, here're my five cents. :-)

tl;dr
We're not using GraphQL API. It would be okay for me, if you remove the support for it (although it would be cool having a brand new neat solution).

detailed
With my company, we've created a custom implementation of Rocket.Chat with our website. For that, we're using both the REST API and the Realtime API via ddp.
In fact, we'd have a bunch of possible features & improvements where a generic GraphQL API would be appreciated.

For Example:
Displaying incoming messages to a certain channel (which is connected to an entity on the website).

To achieve that even for anonymous users (or at least those who're not part of the channel), we experimented with the Rocket.Chat GraphQL API.
But that's not production-ready, so removing your GraphQL implementation wouldn't affect us.

@engelgabriel
Copy link
Member Author

@winterstefan thanks for the heads up! I'll keep you in the look when we start a new implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants