chore: Replace some cursor.count calls with countDocuments or `es…

…timatedDocumentCount` (#33671)

apps/meteor/app/statistics/server/lib/statistics.ts

@@ -126,10 +126,10 @@ export const statistics = {
 
 		// Room statistics
 		statistics.totalRooms = await Rooms.col.countDocuments({});
-		statistics.totalChannels = await Rooms.findByType('c').count();
-		statistics.totalPrivateGroups = await Rooms.findByType('p').count();
-		statistics.totalDirect = await Rooms.findByType('d').count();
-		statistics.totalLivechat = await Rooms.findByType('l').count();
+		statistics.totalChannels = await Rooms.countByType('c');
+		statistics.totalPrivateGroups = await Rooms.countByType('p');
+		statistics.totalDirect = await Rooms.countByType('d');
+		statistics.totalLivechat = await Rooms.countByType('l');
 		statistics.totalDiscussions = await Rooms.countDiscussions();
 		statistics.totalThreads = await Messages.countThreads();
 
@@ -183,7 +183,7 @@ export const statistics = {
 
 		// Number of triggers
 		statsPms.push(
-			LivechatTrigger.col.count().then((count) => {
+			LivechatTrigger.estimatedDocumentCount().then((count) => {
 				statistics.totalTriggers = count;
 			}),
 		);
@@ -205,13 +205,13 @@ export const statistics = {
 
 		// Number of Email Inboxes
 		statsPms.push(
-			EmailInbox.col.count().then((count) => {
+			EmailInbox.estimatedDocumentCount().then((count) => {
 				statistics.emailInboxes = count;
 			}),
 		);
 
 		statsPms.push(
-			LivechatBusinessHours.col.count().then((count) => {
+			LivechatBusinessHours.estimatedDocumentCount().then((count) => {
 				statistics.BusinessHours = {
 					// Number of Business Hours
 					total: count,
@@ -556,7 +556,7 @@ export const statistics = {
 		statistics.totalUserEmail2fa = await Users.countActiveUsersEmail2faEnable({ readPreference });
 		statistics.totalPinned = await Messages.findPinned({ readPreference }).count();
 		statistics.totalStarred = await Messages.findStarred({ readPreference }).count();
-		statistics.totalLinkInvitation = await Invites.find().count();
+		statistics.totalLinkInvitation = await Invites.estimatedDocumentCount();
 		statistics.totalLinkInvitationUses = await Invites.countUses();
 		statistics.totalEmailInvitation = settings.get('Invitation_Email_Count');
 		statistics.totalE2ERooms = await Rooms.findByE2E({ readPreference }).count();

apps/meteor/package.json

@@ -15,7 +15,7 @@
 	"scripts": {
 		"start": "meteor",
 		"build:ci": "METEOR_DISABLE_OPTIMISTIC_CACHING=1 meteor build --server-only --directory /tmp/dist",
-		"dev": "meteor --exclude-archs \"web.browser.legacy, web.cordova\"",
+		"dev": "NODE_OPTIONS=\"--trace-warnings\" meteor --exclude-archs \"web.browser.legacy, web.cordova\"",
 		"dsv": "meteor npm run dev",
 		"ha": "meteor npm run ha:start",
 		"ms": "TRANSPORTER=${TRANSPORTER:-TCP} meteor npm run dev",

apps/meteor/server/models/raw/BaseRaw.ts

@@ -28,6 +28,7 @@ import type {
 	DeleteResult,
 	DeleteOptions,
 	FindOneAndDeleteOptions,
+	CountDocumentsOptions,
 } from 'mongodb';
 
 import { setUpdatedAt } from './setUpdatedAt';
@@ -497,7 +498,10 @@ export abstract class BaseRaw<
 		return this.col.watch(pipeline);
 	}
 
-	countDocuments(query: Filter<T>): Promise<number> {
+	countDocuments(query: Filter<T>, options?: CountDocumentsOptions): Promise<number> {
+		if (options) {
+			return this.col.countDocuments(query, options);
+		}
 		return this.col.countDocuments(query);
 	}
 

apps/meteor/server/models/raw/NpsVote.ts

@@ -97,4 +97,17 @@ export class NpsVoteRaw extends BaseRaw<INpsVote> implements INpsVoteModel {
 		};
 		return this.updateMany(query, update);
 	}
+
+	countByNpsId(npsId: string): Promise<number> {
+		return this.countDocuments({ npsId });
+	}
+
+	countByNpsIdAndStatus(npsId: string, status: INpsVoteStatus): Promise<number> {
+		const query = {
+			npsId,
+			status,
+		};
+
+		return this.countDocuments(query);
+	}
 }

apps/meteor/server/models/raw/Rooms.ts

@@ -224,6 +224,17 @@ export class RoomsRaw extends BaseRaw<IRoom> implements IRoomsModel {
 		return this.find(query, options);
 	}
 
+	countByTeamId(teamId: ITeam['_id']): Promise<number> {
+		const query: Filter<IRoom> = {
+			teamId,
+			teamMain: {
+				$exists: false,
+			},
+		};
+
+		return this.countDocuments(query);
+	}
+
 	findPaginatedByTeamIdContainingNameAndDefault(
 		teamId: ITeam['_id'],
 		name: IRoom['name'],
@@ -702,6 +713,14 @@ export class RoomsRaw extends BaseRaw<IRoom> implements IRoomsModel {
 		});
 	}
 
+	countRoomsInsideTeams(autoJoin = false): Promise<number> {
+		return this.countDocuments({
+			teamId: { $exists: true },
+			teamMain: { $exists: false },
+			...(autoJoin && { teamDefault: true }),
+		});
+	}
+
 	countByType(t: IRoom['t']): Promise<number> {
 		return this.col.countDocuments({ t });
 	}

apps/meteor/server/models/raw/ServerEvents.ts

@@ -55,36 +55,36 @@ export class ServerEventsRaw extends BaseRaw<IServerEvent> implements IServerEve
 	}
 
 	async countFailedAttemptsByUsernameSince(username: string, since: Date): Promise<number> {
-		return this.find({
+		return this.countDocuments({
 			'u.username': username,
 			't': ServerEventType.FAILED_LOGIN_ATTEMPT,
 			'ts': {
 				$gte: since,
 			},
-		}).count();
+		});
 	}
 
 	countFailedAttemptsByIpSince(ip: string, since: Date): Promise<number> {
-		return this.find({
+		return this.countDocuments({
 			ip,
 			t: ServerEventType.FAILED_LOGIN_ATTEMPT,
 			ts: {
 				$gte: since,
 			},
-		}).count();
+		});
 	}
 
 	countFailedAttemptsByIp(ip: string): Promise<number> {
-		return this.find({
+		return this.countDocuments({
 			ip,
 			t: ServerEventType.FAILED_LOGIN_ATTEMPT,
-		}).count();
+		});
 	}
 
 	countFailedAttemptsByUsername(username: string): Promise<number> {
-		return this.find({
+		return this.countDocuments({
 			'u.username': username,
 			't': ServerEventType.FAILED_LOGIN_ATTEMPT,
-		}).count();
+		});
 	}
 }

apps/meteor/server/models/raw/TeamMember.ts

@@ -72,6 +72,10 @@ export class TeamMemberRaw extends BaseRaw<ITeamMember> implements ITeamMemberMo
 		return options ? this.col.find({ teamId }, options) : this.col.find({ teamId }, options);
 	}
 
+	countByTeamId(teamId: string): Promise<number> {
+		return this.countDocuments({ teamId });
+	}
+
 	findByTeamIds(teamIds: Array<string>): FindCursor<ITeamMember>;
 
 	findByTeamIds(teamIds: Array<string>, options: FindOptions<ITeamMember>): FindCursor<ITeamMember>;
@@ -99,6 +103,10 @@ export class TeamMemberRaw extends BaseRaw<ITeamMember> implements ITeamMemberMo
 		return options ? this.col.find({ teamId, roles: role }, options) : this.col.find({ teamId, roles: role });
 	}
 
+	countByTeamIdAndRole(teamId: string, role: IRole['_id']): Promise<number> {
+		return this.countDocuments({ teamId, roles: role });
+	}
+
 	findByUserIdAndTeamIds(userId: string, teamIds: Array<string>, options: FindOptions<ITeamMember> = {}): FindCursor<ITeamMember> {
 		const query = {
 			userId,

apps/meteor/server/models/raw/VideoConference.ts

@@ -8,7 +8,16 @@ import type {
 } from '@rocket.chat/core-typings';
 import { VideoConferenceStatus } from '@rocket.chat/core-typings';
 import type { FindPaginated, InsertionModel, IVideoConferenceModel } from '@rocket.chat/model-typings';
-import type { FindCursor, UpdateOptions, UpdateFilter, UpdateResult, IndexDescription, Collection, Db, FindOptions } from 'mongodb';
+import type {
+	FindCursor,
+	UpdateOptions,
+	UpdateFilter,
+	UpdateResult,
+	IndexDescription,
+	Collection,
+	Db,
+	CountDocumentsOptions,
+} from 'mongodb';
 
 import { BaseRaw } from './BaseRaw';
 
@@ -63,15 +72,15 @@ export class VideoConferenceRaw extends BaseRaw<VideoConference> implements IVid
 	public async countByTypeAndStatus(
 		type: VideoConference['type'],
 		status: VideoConferenceStatus,
-		options: FindOptions<VideoConference>,
+		options: CountDocumentsOptions,
 	): Promise<number> {
-		return this.find(
+		return this.countDocuments(
 			{
 				type,
 				status,
 			},
 			options,
-		).count();
+		);
 	}
 
 	public async createDirect({

apps/meteor/server/services/nps/service.ts

@@ -60,14 +60,14 @@ export class NPSService extends ServiceClassInternal implements INPSService {
 			return;
 		}
 
-		const total = await NpsVote.findByNpsId(nps._id).count();
+		const total = await NpsVote.countByNpsId(nps._id);
 
 		const votesToSend = await NpsVote.findNotSentByNpsId(nps._id).toArray();
 
 		// if there is nothing to sent, check if something gone wrong
 		if (votesToSend.length === 0) {
 			// check if still has votes left to send
-			const totalSent = await NpsVote.findByNpsIdAndStatus(nps._id, INpsVoteStatus.SENT).count();
+			const totalSent = await NpsVote.countByNpsIdAndStatus(nps._id, INpsVoteStatus.SENT);
 			if (totalSent === total) {
 				await Nps.updateStatusById(nps._id, NPSStatus.SENT);
 				return;
@@ -130,7 +130,7 @@ export class NPSService extends ServiceClassInternal implements INPSService {
 			await NpsVote.updateVotesToSent(voteIds);
 		}
 
-		const totalSent = await NpsVote.findByNpsIdAndStatus(nps._id, INpsVoteStatus.SENT).count();
+		const totalSent = await NpsVote.countByNpsIdAndStatus(nps._id, INpsVoteStatus.SENT);
 		if (totalSent < total) {
 			// send more in five minutes
 			setTimeout(() => NPS.sendResults(), 5 * 60 * 1000);

apps/meteor/server/services/team/service.ts

@@ -251,12 +251,10 @@ export class TeamService extends ServiceClassInternal implements ITeamService {
 
 		const results: ITeamInfo[] = [];
 		for await (const record of records) {
-			const rooms = Rooms.findByTeamId(record._id);
-			const users = TeamMember.findByTeamId(record._id);
 			results.push({
 				...record,
-				rooms: await rooms.count(),
-				numberOfUsers: await users.count(),
+				rooms: await Rooms.countByTeamId(record._id),
+				numberOfUsers: await TeamMember.countByTeamId(record._id),
 			});
 		}
 
@@ -279,12 +277,10 @@ export class TeamService extends ServiceClassInternal implements ITeamService {
 
 		const results: ITeamInfo[] = [];
 		for await (const record of records) {
-			const rooms = Rooms.findByTeamId(record._id);
-			const users = TeamMember.findByTeamId(record._id);
 			results.push({
 				...record,
-				rooms: await rooms.count(),
-				numberOfUsers: await users.count(),
+				rooms: await Rooms.countByTeamId(record._id),
+				numberOfUsers: await TeamMember.countByTeamId(record._id),
 			});
 		}
 
@@ -797,8 +793,7 @@ export class TeamService extends ServiceClassInternal implements ITeamService {
 
 			if (existingMember) {
 				if (existingMember.roles?.includes('owner')) {
-					const owners = TeamMember.findByTeamIdAndRole(team._id, 'owner');
-					const totalOwners = await owners.count();
+					const totalOwners = await TeamMember.countByTeamIdAndRole(team._id, 'owner');
 					if (totalOwners === 1) {
 						throw new Error('last-owner-can-not-be-removed');
 					}
@@ -1002,9 +997,9 @@ export class TeamService extends ServiceClassInternal implements ITeamService {
 
 	async getStatistics(): Promise<ITeamStats> {
 		return {
-			totalTeams: await Team.find({}).count(),
-			totalRoomsInsideTeams: await Rooms.findRoomsInsideTeams().count(),
-			totalDefaultRoomsInsideTeams: await Rooms.findRoomsInsideTeams(true).count(),
+			totalTeams: await Team.estimatedDocumentCount(),
+			totalRoomsInsideTeams: await Rooms.countRoomsInsideTeams(),
+			totalDefaultRoomsInsideTeams: await Rooms.countRoomsInsideTeams(true),
 		};
 	}
 

packages/model-typings/src/models/INpsVoteModel.ts

@@ -10,4 +10,6 @@ export interface INpsVoteModel extends IBaseModel<INpsVote> {
 	save(vote: Omit<INpsVote, '_id' | '_updatedAt'>): Promise<UpdateResult>;
 	updateVotesToSent(voteIds: string[]): Promise<UpdateResult | Document>;
 	updateOldSendingToNewByNpsId(npsId: string): Promise<UpdateResult | Document>;
+	countByNpsId(npsId: string): Promise<number>;
+	countByNpsIdAndStatus(npsId: string, status: INpsVoteStatus): Promise<number>;
 }

packages/model-typings/src/models/IRoomsModel.ts

@@ -49,6 +49,8 @@ export interface IRoomsModel extends IBaseModel<IRoom> {
 
 	findByTeamId(teamId: ITeam['_id'], options?: FindOptions<IRoom>): FindCursor<IRoom>;
 
+	countByTeamId(teamId: ITeam['_id']): Promise<number>;
+
 	findPaginatedByTeamIdContainingNameAndDefault(
 		teamId: ITeam['_id'],
 		name: IRoom['name'],
@@ -139,6 +141,8 @@ export interface IRoomsModel extends IBaseModel<IRoom> {
 
 	findRoomsInsideTeams(autoJoin?: boolean): FindCursor<IRoom>;
 
+	countRoomsInsideTeams(autoJoin?: boolean): Promise<number>;
+
 	findOneDirectRoomContainingAllUserIDs(uid: IDirectMessageRoom['uids'], options?: FindOptions<IRoom>): Promise<IRoom | null>;
 
 	countByType(t: IRoom['t']): Promise<number>;

packages/model-typings/src/models/ITeamMemberModel.ts

@@ -38,6 +38,7 @@ export interface ITeamMemberModel extends IBaseModel<ITeamMember> {
 		options?: undefined | FindOptions<ITeamMember> | FindOptions<P extends ITeamMember ? ITeamMember : P>,
 	): FindCursor<P> | FindCursor<ITeamMember>;
 
+	countByTeamId(teamId: string): Promise<number>;
 	findByTeamIds(teamIds: Array<string>): FindCursor<ITeamMember>;
 
 	findByTeamIds(teamIds: Array<string>, options: FindOptions<ITeamMember>): FindCursor<ITeamMember>;
@@ -61,6 +62,8 @@ export interface ITeamMemberModel extends IBaseModel<ITeamMember> {
 		options?: undefined | FindOptions<ITeamMember> | FindOptions<P extends ITeamMember ? ITeamMember : P>,
 	): FindCursor<P> | FindCursor<ITeamMember>;
 
+	countByTeamIdAndRole(teamId: string, role: IRole['_id']): Promise<number>;
+
 	findByUserIdAndTeamIds(userId: string, teamIds: Array<string>, options?: FindOptions<ITeamMember>): FindCursor<ITeamMember>;
 
 	findPaginatedMembersInfoByTeamId(