Skip to content

Commit

Permalink
fix: add withErrorBoundary to BannerRegion (#33689)
Browse files Browse the repository at this point in the history
  • Loading branch information
MartinSchoeler authored and abhinavkrin committed Oct 25, 2024
1 parent 0c63903 commit 30e21dc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/real-jeans-worry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixes banner breaking the UI with specific payloads
3 changes: 2 additions & 1 deletion apps/meteor/client/views/banners/BannerRegion.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { ReactElement } from 'react';
import React from 'react';
import { useSyncExternalStore } from 'use-sync-external-store/shim';

import { withErrorBoundary } from '../../components/withErrorBoundary';
import * as banners from '../../lib/banners';
import LegacyBanner from './LegacyBanner';
import UiKitBanner from './UiKitBanner';
Expand All @@ -23,4 +24,4 @@ const BannerRegion = (): ReactElement | null => {
return <UiKitBanner key={payload.viewId} initialView={payload} />;
};

export default BannerRegion;
export default withErrorBoundary(BannerRegion);

0 comments on commit 30e21dc

Please sign in to comment.