From d9933f5f41625e149186d95455256fc97407faec Mon Sep 17 00:00:00 2001
From: CYCLOPS <cyclops.sh@gmail.com>
Date: Tue, 9 Jan 2018 19:50:16 +0330
Subject: [PATCH 01/11] fix-announcement-bar-color

---
 packages/rocketchat-theme/client/imports/general/base_old.css | 3 +--
 packages/rocketchat-theme/server/colors.less                  | 4 ++++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/packages/rocketchat-theme/client/imports/general/base_old.css b/packages/rocketchat-theme/client/imports/general/base_old.css
index 9766649cff2c..5834fc26562e 100644
--- a/packages/rocketchat-theme/client/imports/general/base_old.css
+++ b/packages/rocketchat-theme/client/imports/general/base_old.css
@@ -1733,8 +1733,7 @@
 	white-space: nowrap;
 	text-overflow: ellipsis;
 
-	color: white;
-	background-color: #04436a;
+	color: var(--rc-color-content);
 
 	font-size: 1.2em;
 	line-height: 40px;
diff --git a/packages/rocketchat-theme/server/colors.less b/packages/rocketchat-theme/server/colors.less
index 882e768a516a..1e0e027d2a89 100755
--- a/packages/rocketchat-theme/server/colors.less
+++ b/packages/rocketchat-theme/server/colors.less
@@ -953,3 +953,7 @@ label.required::after {
 .range-slider-range::-moz-range-track {
 	background-color: @tertiary-background-color;
 }
+
+.announcement {
+	background-color: @primary-background-color;
+}

From 685b8f2be9cc86957da817202d8d68bc61559838 Mon Sep 17 00:00:00 2001
From: Karl Prieb <karl@prieb.me>
Date: Thu, 22 Feb 2018 16:22:41 -0300
Subject: [PATCH 02/11] Reactivate API tests

---
 tests/chimp-config.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/chimp-config.js b/tests/chimp-config.js
index 46fb2a6c369a..d03dcfc8273a 100644
--- a/tests/chimp-config.js
+++ b/tests/chimp-config.js
@@ -19,7 +19,7 @@ module.exports = {
 // 	showXolvioMessages: true,
 
 // 	// - - - - CUCUMBER - - - -
-	path: 'tests/end-to-end/ui',
+	path: 'tests/end-to-end',
 	// 	format: 'pretty',
 	// 	tags: '~@ignore',
 	// 	singleSnippetPerFile: true,

From 8cc1ccce595127a4945dca401be7c376edcf5108 Mon Sep 17 00:00:00 2001
From: Marcos Defendi <marcos.defendi@ulbra.inf.br>
Date: Mon, 26 Feb 2018 15:19:24 -0300
Subject: [PATCH 03/11] trying fix error on ui tests

---
 tests/end-to-end/ui/06-messaging.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/end-to-end/ui/06-messaging.js b/tests/end-to-end/ui/06-messaging.js
index 046ac2247f3f..2da8a28aa9c1 100644
--- a/tests/end-to-end/ui/06-messaging.js
+++ b/tests/end-to-end/ui/06-messaging.js
@@ -267,6 +267,7 @@ describe('[Message]', () => {
 
 	describe('[GENERAL Channel]', () => {
 		before(()=>{
+			checkIfUserIsValid(username, email, password);
 			sideNav.spotlightSearchIcon.click();
 			sideNav.spotlightSearch.waitForVisible(10000);
 			sideNav.searchChannel('general');

From 201a85b10d48bc6583fdd9eaaf741985a5d9f06d Mon Sep 17 00:00:00 2001
From: Kai Alexander Fischer <kai@i7x.de>
Date: Tue, 27 Feb 2018 22:59:02 +0100
Subject: [PATCH 04/11] Set autocomplete to off (disabled).

---
 packages/rocketchat-ui-flextab/client/tabs/userEdit.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/rocketchat-ui-flextab/client/tabs/userEdit.html b/packages/rocketchat-ui-flextab/client/tabs/userEdit.html
index 9eb49f5af292..41285ff3a39e 100644
--- a/packages/rocketchat-ui-flextab/client/tabs/userEdit.html
+++ b/packages/rocketchat-ui-flextab/client/tabs/userEdit.html
@@ -2,7 +2,7 @@
 	{{#unless canEditOrAdd}}
 		<p class="secondary-font-color">{{_ "You_are_not_authorized_to_view_this_page"}}</p>
 	{{else}}
-	<form class="" action="index.html" method="post" >
+	<form class="" action="index.html" method="post" autocomplete="off">
 		<div class="rc-input rc-form-group rc-form-group--small">
 			<label class="rc-input__label">
 				<div class="rc-input__title">{{_ "Name"}}</div>

From bf7402597e7cd5095953fbac88fc686ef87ddd7a Mon Sep 17 00:00:00 2001
From: Karl Prieb <karl@prieb.me>
Date: Mon, 5 Mar 2018 14:50:54 -0300
Subject: [PATCH 05/11] Avatar input accepts only PNG, JPG and GIF

---
 packages/rocketchat-ui-account/client/accountProfile.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/rocketchat-ui-account/client/accountProfile.html b/packages/rocketchat-ui-account/client/accountProfile.html
index f1a2581b44de..d8300889e5c4 100644
--- a/packages/rocketchat-ui-account/client/accountProfile.html
+++ b/packages/rocketchat-ui-account/client/accountProfile.html
@@ -42,7 +42,7 @@
 													<label class="rc-select-avatar__upload-label avatar" for="upload-avatar">
 														{{> icon block="rc-select-avatar__upload-icon" icon="upload"}}
 													</label>
-													<input type="file" name="" value="" id="upload-avatar" style="display:none;">
+													<input type="file" name="" value="" id="upload-avatar" style="display:none;" accept="image/x-png,image/gif,image/jpeg">
 												</div>
 												<div class="rc-select-avatar__list-item rc-tooltip js-select-avatar-url {{selectUrl}}"  aria-label="{{_ "Use_url_for_avatar" }}">
 													<label class="rc-select-avatar__upload-label avatar">

From e356d7f9a28417e8f66352187567cdb85575c3bc Mon Sep 17 00:00:00 2001
From: Karl Prieb <karl@prieb.me>
Date: Tue, 6 Mar 2018 11:42:17 -0300
Subject: [PATCH 06/11] fix initial loading feedback

---
 .../rocketchat-livechat/.app/client/views/loading.html   | 8 ++++----
 .../rocketchat-theme/client/imports/general/base.css     | 2 ++
 packages/rocketchat-ui-master/server/inject.js           | 9 ++++-----
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/packages/rocketchat-livechat/.app/client/views/loading.html b/packages/rocketchat-livechat/.app/client/views/loading.html
index e13a3f77ba1c..77310699f18a 100644
--- a/packages/rocketchat-livechat/.app/client/views/loading.html
+++ b/packages/rocketchat-livechat/.app/client/views/loading.html
@@ -1,8 +1,8 @@
 <template name="loading">
 	<div class="loading-animation">
 		{{_ "Connecting to an Agent"}}
-		<div class="bounce1"></div>
-		<div class="bounce2"></div>
-		<div class="bounce3"></div>
+		<div class="bounce bounce1"></div>
+		<div class="bounce bounce2"></div>
+		<div class="bounce bounce3"></div>
 	</div>
-</template>
\ No newline at end of file
+</template>
diff --git a/packages/rocketchat-theme/client/imports/general/base.css b/packages/rocketchat-theme/client/imports/general/base.css
index 28a4e7342769..04202e9243f8 100644
--- a/packages/rocketchat-theme/client/imports/general/base.css
+++ b/packages/rocketchat-theme/client/imports/general/base.css
@@ -30,6 +30,8 @@ body {
 	font-size: var(--text-small-size);
 	-webkit-font-smoothing: antialiased;
 	-moz-osx-font-smoothing: grayscale;
+
+	background-color: var(--rc-color-primary)
 }
 
 :focus {
diff --git a/packages/rocketchat-ui-master/server/inject.js b/packages/rocketchat-ui-master/server/inject.js
index 4f70c56de2da..7f45db12a178 100644
--- a/packages/rocketchat-ui-master/server/inject.js
+++ b/packages/rocketchat-ui-master/server/inject.js
@@ -36,9 +36,9 @@ Inject.rawBody('icons', Assets.getText('public/icons.svg'));
 Inject.rawBody('page-loading-div', `
 <div id="initial-page-loading" class="page-loading">
 	<div class="loading-animation">
-		<div class="bounce1"></div>
-		<div class="bounce2"></div>
-		<div class="bounce3"></div>
+		<div class="bounce bounce1"></div>
+		<div class="bounce bounce2"></div>
+		<div class="bounce bounce3"></div>
 	</div>
 </div>`);
 
@@ -71,8 +71,7 @@ RocketChat.settings.get('Assets_SvgFavicon_Enable', (key, value) => {
 });
 
 RocketChat.settings.get('theme-color-sidebar-background', (key, value) => {
-	Inject.rawHead(key, `<style>body { background-color: ${ value };}</style>` +
-						`<meta name="msapplication-TileColor" content="${ value }" />` +
+	Inject.rawHead(key, `<meta name="msapplication-TileColor" content="${ value }" />` +
 						`<meta name="theme-color" content="${ value }" />`);
 });
 

From 2249507858ec135cee7568a41b2f5378b6a9eec5 Mon Sep 17 00:00:00 2001
From: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
Date: Tue, 6 Mar 2018 11:48:46 -0300
Subject: [PATCH 07/11] [FIX] Download links was duplicating Sub Paths

---
 packages/rocketchat-file-upload/server/lib/requests.js          | 2 +-
 .../rocketchat-message-attachments/client/messageAttachment.js  | 2 +-
 packages/rocketchat-ui-flextab/client/tabs/uploadedFilesList.js | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/rocketchat-file-upload/server/lib/requests.js b/packages/rocketchat-file-upload/server/lib/requests.js
index 7a47c0496e81..7962e095351f 100644
--- a/packages/rocketchat-file-upload/server/lib/requests.js
+++ b/packages/rocketchat-file-upload/server/lib/requests.js
@@ -1,6 +1,6 @@
 /* globals FileUpload, WebApp */
 
-WebApp.connectHandlers.use(`${ __meteor_runtime_config__.ROOT_URL_PATH_PREFIX }/file-upload/`,	function(req, res, next) {
+WebApp.connectHandlers.use('/file-upload/',	function(req, res, next) {
 
 	const match = /^\/([^\/]+)\/(.*)/.exec(req.url);
 
diff --git a/packages/rocketchat-message-attachments/client/messageAttachment.js b/packages/rocketchat-message-attachments/client/messageAttachment.js
index 8da6606bca34..d0df4d8f3b5f 100644
--- a/packages/rocketchat-message-attachments/client/messageAttachment.js
+++ b/packages/rocketchat-message-attachments/client/messageAttachment.js
@@ -22,7 +22,7 @@ const fixCordova = function(url) {
 	} else if (navigator.userAgent.indexOf('Electron') > -1) {
 		return __meteor_runtime_config__.ROOT_URL_PATH_PREFIX + url;
 	} else {
-		return Meteor.absoluteUrl().replace(/\/$/, '') + __meteor_runtime_config__.ROOT_URL_PATH_PREFIX + url;
+		return Meteor.absoluteUrl().replace(/\/$/, '') + url;
 	}
 };
 /*globals renderMessageBody*/
diff --git a/packages/rocketchat-ui-flextab/client/tabs/uploadedFilesList.js b/packages/rocketchat-ui-flextab/client/tabs/uploadedFilesList.js
index e93b82b6af18..75aededa69b7 100644
--- a/packages/rocketchat-ui-flextab/client/tabs/uploadedFilesList.js
+++ b/packages/rocketchat-ui-flextab/client/tabs/uploadedFilesList.js
@@ -23,7 +23,7 @@ const fixCordova = (url) => {
 	} else if (navigator.userAgent.indexOf('Electron') > -1) {
 		return __meteor_runtime_config__.ROOT_URL_PATH_PREFIX + url;
 	} else {
-		return Meteor.absoluteUrl().replace(/\/$/, '') + __meteor_runtime_config__.ROOT_URL_PATH_PREFIX + url;
+		return Meteor.absoluteUrl().replace(/\/$/, '') + url;
 	}
 };
 

From 2fd19cbf72fe22e2a105bca7afa5418cd92378d6 Mon Sep 17 00:00:00 2001
From: Karl Prieb <karl@prieb.me>
Date: Tue, 6 Mar 2018 14:47:33 -0300
Subject: [PATCH 08/11] move loading animation css to css bundle

---
 .../client/imports/general/base.css           | 49 +++++++++++++++++++
 packages/rocketchat-ui-master/package.js      |  1 -
 .../rocketchat-ui-master/public/loading.css   | 48 ------------------
 .../rocketchat-ui-master/server/inject.js     |  2 -
 4 files changed, 49 insertions(+), 51 deletions(-)
 delete mode 100644 packages/rocketchat-ui-master/public/loading.css

diff --git a/packages/rocketchat-theme/client/imports/general/base.css b/packages/rocketchat-theme/client/imports/general/base.css
index 04202e9243f8..f4a7f3adcdab 100644
--- a/packages/rocketchat-theme/client/imports/general/base.css
+++ b/packages/rocketchat-theme/client/imports/general/base.css
@@ -207,3 +207,52 @@ button {
 .hidden {
 	display: none;
 }
+
+.loading-animation {
+	position: absolute;
+	top: 0;
+	right: 0;
+	bottom: 0;
+	left: 0;
+
+	display: flex;
+
+	text-align: center;
+	align-items: center;
+	justify-content: center;
+}
+
+.loading-animation > .bounce {
+	display: inline-block;
+
+	width: 10px;
+	height: 10px;
+	margin: 2px;
+
+	animation: loading-bouncedelay 1.4s infinite ease-in-out both;
+
+	border-radius: 100%;
+	background-color: rgba(255, 255, 255, 0.6);
+}
+
+.loading-animation .bounce1 {
+	-webkit-animation-delay: -0.32s;
+	animation-delay: -0.32s;
+}
+
+.loading-animation .bounce2 {
+	-webkit-animation-delay: -0.16s;
+	animation-delay: -0.16s;
+}
+
+@keyframes loading-bouncedelay {
+	0%,
+	80%,
+	100% {
+		transform: scale(0);
+	}
+
+	40% {
+		transform: scale(1);
+	}
+}
diff --git a/packages/rocketchat-ui-master/package.js b/packages/rocketchat-ui-master/package.js
index dedf7eea4e99..e2b51652edf8 100644
--- a/packages/rocketchat-ui-master/package.js
+++ b/packages/rocketchat-ui-master/package.js
@@ -28,5 +28,4 @@ Package.onUse(function(api) {
 
 	api.addFiles('server/inject.js', 'server');
 	api.addAssets('public/icons.svg', 'server');
-	api.addAssets('public/loading.css', 'server');
 });
diff --git a/packages/rocketchat-ui-master/public/loading.css b/packages/rocketchat-ui-master/public/loading.css
deleted file mode 100644
index 42984694f28c..000000000000
--- a/packages/rocketchat-ui-master/public/loading.css
+++ /dev/null
@@ -1,48 +0,0 @@
-.loading-animation {
-	position: absolute;
-	top: 0;
-	right: 0;
-	bottom: 0;
-	left: 0;
-
-	display: flex;
-
-	text-align: center;
-	align-items: center;
-	justify-content: center;
-}
-
-.loading-animation > .bounce {
-	display: inline-block;
-
-	width: 10px;
-	height: 10px;
-	margin: 2px;
-
-	animation: loading-bouncedelay 1.4s infinite ease-in-out both;
-
-	border-radius: 100%;
-	background-color: rgba(255, 255, 255, 0.6);
-}
-
-.loading-animation .bounce1 {
-	-webkit-animation-delay: -0.32s;
-	animation-delay: -0.32s;
-}
-
-.loading-animation .bounce2 {
-	-webkit-animation-delay: -0.16s;
-	animation-delay: -0.16s;
-}
-
-@keyframes loading-bouncedelay {
-	0%,
-	80%,
-	100% {
-		transform: scale(0);
-	}
-
-	40% {
-		transform: scale(1);
-	}
-}
diff --git a/packages/rocketchat-ui-master/server/inject.js b/packages/rocketchat-ui-master/server/inject.js
index 7f45db12a178..d83897f88900 100644
--- a/packages/rocketchat-ui-master/server/inject.js
+++ b/packages/rocketchat-ui-master/server/inject.js
@@ -29,8 +29,6 @@ RocketChat.models.Settings.find({_id:/theme-color-rc/i}, {fields: { value: 1}}).
 
 Inject.rawHead('dynamic', `<script>(${ require('./dynamic-css.js').default.toString().replace(/\/\/.*?\n/g, '') })()</script>`);
 
-Inject.rawHead('page-loading', `<style>${ Assets.getText('public/loading.css') }</style>`);
-
 Inject.rawBody('icons', Assets.getText('public/icons.svg'));
 
 Inject.rawBody('page-loading-div', `

From cfc797a53696a5923935669e1d7ab3ecf2cf5558 Mon Sep 17 00:00:00 2001
From: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
Date: Tue, 6 Mar 2018 18:59:46 -0300
Subject: [PATCH 09/11] [OTHER] Reactivate all tests

---
 tests/end-to-end/ui/11-admin.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/end-to-end/ui/11-admin.js b/tests/end-to-end/ui/11-admin.js
index 4ab801cce0c2..0c7c33762fcc 100644
--- a/tests/end-to-end/ui/11-admin.js
+++ b/tests/end-to-end/ui/11-admin.js
@@ -22,7 +22,7 @@ describe('[Administration]', () => {
 		sideNav.preferencesClose.click();
 	});
 
-	describe.only('[Admin View]', () => {
+	describe('[Admin View]', () => {
 		before(() => {
 			sideNav.sidebarMenu.click();
 			sideNav.admin.waitForVisible(5000);

From 204a2c2e0958e95ad310daf3f743ce06be8214a9 Mon Sep 17 00:00:00 2001
From: Hudell <brian@hudell.com>
Date: Wed, 7 Mar 2018 15:55:23 -0300
Subject: [PATCH 10/11] Fixed issue that caused user preferences to not be
 saved when roles are hidden in the admin settings

---
 packages/rocketchat-ui-account/client/accountPreferences.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/packages/rocketchat-ui-account/client/accountPreferences.js b/packages/rocketchat-ui-account/client/accountPreferences.js
index 8bc65c6e16c9..07487576d60f 100644
--- a/packages/rocketchat-ui-account/client/accountPreferences.js
+++ b/packages/rocketchat-ui-account/client/accountPreferences.js
@@ -135,7 +135,6 @@ Template.accountPreferences.onCreated(function() {
 		data.muteFocusedConversations = JSON.parse($('#muteFocusedConversations').find('input:checked').val());
 		data.viewMode = parseInt($('#viewMode').find('select').val());
 		data.hideUsernames = JSON.parse($('#hideUsernames').find('input:checked').val());
-		data.hideRoles = JSON.parse($('#hideRoles').find('input:checked').val());
 		data.hideFlexTab = JSON.parse($('#hideFlexTab').find('input:checked').val());
 		data.hideAvatars = JSON.parse($('#hideAvatars').find('input:checked').val());
 		data.sendOnEnter = $('#sendOnEnter').find('select').val();
@@ -153,6 +152,10 @@ Template.accountPreferences.onCreated(function() {
 
 		let reload = false;
 
+		if (RocketChat.settings.get('UI_DisplayRoles')) {
+			data.hideRoles = JSON.parse($('#hideRoles').find('input:checked').val());
+		}
+
 		// if highlights changed we need page reload
 		const highlights = RocketChat.getUserPreference(Meteor.user(), 'highlights');
 		if (highlights && highlights.join('\n') !== data.highlights.join('\n')) {

From f3f16de54758b0b43431a2deb22f4acf065872a3 Mon Sep 17 00:00:00 2001
From: Diego Sampaio <chinello@gmail.com>
Date: Thu, 8 Mar 2018 10:39:08 -0300
Subject: [PATCH 11/11] Fix adding read receipts on message editing

---
 imports/message-read-receipt/server/hooks.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/imports/message-read-receipt/server/hooks.js b/imports/message-read-receipt/server/hooks.js
index 560ebf449ac4..4039271580e4 100644
--- a/imports/message-read-receipt/server/hooks.js
+++ b/imports/message-read-receipt/server/hooks.js
@@ -2,6 +2,11 @@ import { ReadReceipt } from './lib/ReadReceipt';
 
 RocketChat.callbacks.add('afterSaveMessage', (message, room) => {
 
+	// skips this callback if the message was edited
+	if (message.editedAt) {
+		return message;
+	}
+
 	// set subscription as read right after message was sent
 	RocketChat.models.Subscriptions.setAsReadByRoomIdAndUserId(room._id, message.u._id);