Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing orientation inside a room doesn't update keyboard bounds #285

Closed
diegolmello opened this issue Apr 26, 2018 · 7 comments
Closed
Labels

Comments

@diegolmello
Copy link
Member

apr-26-2018 10-45-57

@harshit98
Copy link

Hi @diegolmello 👋 can I work on this issue? :)

@diegolmello
Copy link
Member Author

Hi, @harshit98. Of course, you can!
If you have any questions, just reply here 👊

@harshit98
Copy link

@diegolmello While working on this issue, I've observed that if I refresh the app in my simulator (device being in horizontal position) then the message box appears in full-width equal to screen-size of the device and when I rotate the screen to vertical position, the message box covers the full-bottom width of the device but buttons like microphone and '+' sign (to add files) get out of the screen (or hides away)

simulator screen shot - iphone 6 - 2018-05-10 at 23 40 57
simulator screen shot - iphone 6 - 2018-05-10 at 23 41 50

Looks like the code which is already written is working fine. It can be problem with the Xcode simulator for iPhone 6 11.2 (maybe). Suggestions are welcomed :)

@diegolmello
Copy link
Member Author

@harshit98 Yes, I already opened an issue on wix/react-native-keyboard-input about it.
I wanted your opinion before I tell you.
Can you investigate iOS code?

I already made a fork for Wix's library here: https://github.com/RocketChat/react-native-keyboard-input

@harshit98
Copy link

@diegolmello I can't investigate the iOS code because I'm not familiar with Objective-C. But yes, I can help the team with other issues under this repository. ✨

@diegolmello
Copy link
Member Author

@harshit98 Thanks, man.

@diegolmello
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants