Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better code structure #1

Closed
4 of 5 tasks
rodrigok opened this issue Aug 7, 2017 · 0 comments
Closed
4 of 5 tasks

Better code structure #1

rodrigok opened this issue Aug 7, 2017 · 0 comments

Comments

@rodrigok
Copy link
Member

rodrigok commented Aug 7, 2017 •
edited
Loading

There are some options to improve the code structure:

  • Read the Building Chatty to get ideas
  • Add redux
  • Rename file meteor.js to RocketChat to encapsulate the API to populate realm
  • Separate views to standalone files
  • Integrate Storybook to be able to test state of components
@saketkumar saketkumar mentioned this issue Dec 24, 2017
Closed
@ggazzo ggazzo closed this as completed May 17, 2019
diegolmello pushed a commit that referenced this issue Feb 20, 2020
@Prateek93a
Merge pull request #1 from RocketChat/develop
d0af3c0 
[CHORE] Refactor RoomItem touchable (#1331)
@hp734 hp734 mentioned this issue May 9, 2020
Closed
mullerpeter referenced this issue in Milchjugend/Rocket.Chat.ReactNative May 20, 2020
@zesinho
Merge pull request #1 from raskin/feature/SOL-822
96a7828 
Add Link to WP-Profile from direct chat
@BizClimb BizClimb mentioned this issue Aug 7, 2020
Closed
regalstreak added a commit to regalstreak/Rocket.Chat.ReactNative that referenced this issue Aug 22, 2020
@regalstreak
fix: code review RocketChat#1 (1)
f5fad4e
aenonGit added a commit to VoiSmart/Rocket.Chat.ReactNative that referenced this issue Oct 15, 2020
@aenonGit
RocketChat#1 - add ws method to retrieve user info on ng
c172b89
aenonGit added a commit to VoiSmart/Rocket.Chat.ReactNative that referenced this issue Oct 15, 2020
@aenonGit
RocketChat#1 - add utility to make call via Connect
0e166e5
aenonGit added a commit to VoiSmart/Rocket.Chat.ReactNative that referenced this issue Oct 15, 2020
@aenonGit
RocketChat#1 - make audio and video calls via VoiSmart Connect
6d499c1
aenonGit pushed a commit to VoiSmart/Rocket.Chat.ReactNative that referenced this issue Oct 15, 2020
add scheme to be able to call via Connect on iOS - RocketChat#1
516267c
Alexdc-12 referenced this issue in Alexdc-12/Rocket.Chat.ReactNative Dec 25, 2020
@Alexdc-12
ios merge #1
5f65f3b
@gerzonc gerzonc mentioned this issue Feb 1, 2021
Merged
10 tasks
AmitGiriDev pushed a commit to AmitGiriDev/Rocket.Chat.ReactNative that referenced this issue May 8, 2024
@anirbanpaulcom
Merge pull request RocketChat#1 from RocketChat/develop
e8e42be 
add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rodrigok @ggazzo