Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Add call support to rest endpoint "emoji-custom" #196

Merged
merged 2 commits into from
Jul 31, 2018
Merged

[NEW] Add call support to rest endpoint "emoji-custom" #196

merged 2 commits into from
Jul 31, 2018

Conversation

leonardoaramaki
Copy link
Contributor

@RocketChat/android

@leonardoaramaki leonardoaramaki self-assigned this Jul 20, 2018
@CLAassistant
Copy link

CLAassistant commented Jul 20, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

philipbrito
philipbrito reviewed Jul 20, 2018
View reviewed changes
common/build.gradle
@@ -8,7 +8,7 @@ apply plugin: 'kotlin'
apply plugin: 'kotlin-kapt'
apply plugin: 'org.jetbrains.dokka'

sourceCompatibility = 1.8
sourceCompatibility = JavaVersion.VERSION_1_8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dependencies.gradle
@@ -3,7 +3,7 @@ ext {
kotlin : '1.2.51',
kotlinter : '1.11.2',
coroutine : '0.23.1',
dokka : '0.9.16',
dokka : '0.9.17',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@philipbrito philipbrito merged commit 979bdd3 into develop Jul 31, 2018
@philipbrito philipbrito deleted the emoji-custom-support branch July 31, 2018 12:05
@philipbrito philipbrito mentioned this pull request Jul 31, 2018
Closed
@luciofm luciofm restored the emoji-custom-support branch August 28, 2018 21:36
@luciofm luciofm deleted the emoji-custom-support branch August 28, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipbrito philipbrito philipbrito approved these changes

@luciofm luciofm Awaiting requested review from luciofm

Assignees

@leonardoaramaki leonardoaramaki

Labels
rest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonardoaramaki @CLAassistant @philipbrito