You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On native Android Rocket.Chat versions, there is an issue: in "pinned" message list I can see all previously pinned message, even if they were un-pinned a long time ago.
Client version: 2.3.2 build 2026
Server version: 0.65.1 available on docker hub (database update: 121)
Steps to reproduce:
type a message, mark it "pinned" on the web interface
unpin it on the web interface
go to the pinned message list on the Android app
Expected: the message no longer appears "pinned" on the web interface and on the Android app
Actually: the message no longer appears "pinned" on the web interface but is still pinned in the Android app. And so are messages un-pinned months ago.
I believe the issue is that RocketChatClient.getPinnedMessages returns all pinned messages, regardless if they were unpinned or not at some point.
On native Android Rocket.Chat versions, there is an issue: in "pinned" message list I can see all previously pinned message, even if they were un-pinned a long time ago.
Client version: 2.3.2 build 2026
Server version: 0.65.1 available on docker hub (database update: 121)
Steps to reproduce:
Expected: the message no longer appears "pinned" on the web interface and on the Android app
Actually: the message no longer appears "pinned" on the web interface but is still pinned in the Android app. And so are messages un-pinned months ago.
I believe the issue is that RocketChatClient.getPinnedMessages returns all pinned messages, regardless if they were unpinned or not at some point.
It looks like this condition might not be enough:
https://github.com/RocketChat/Rocket.Chat.Kotlin.SDK/blob/master/core/src/main/kotlin/chat/rocket/core/internal/rest/ChatRoom.kt#L110
compared to what the web app uses:
https://github.com/RocketChat/Rocket.Chat/blob/master/packages/rocketchat-lib/server/models/Messages.js#L246
What do you think ? Could you update the Kotlin SDK to match the web app behavior ?
Thanks for the good work.
The text was updated successfully, but these errors were encountered: