Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Agent Typing Indicator #10

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Conversation

Shailesh351
Copy link
Collaborator

Closes RocketChat#6

Changes

When agent is typing from salesforce console, show typing indicator on LiveChat widget that agent is typing.

Demo

https://youtu.be/bZjp3EamZ90

Depends On

RocketChat/Rocket.Chat#19228 which will be part of next RC release 3.8.0 https://github.com/RocketChat/Rocket.Chat/milestone/214

@PrajvalRaval
Copy link

PrajvalRaval commented Oct 28, 2020

@Shailesh351 I am facing this issue while doing a deploy of the app:

prajvalraval@Prajvals-MacBook-Pro Apps.Salesforce.LiveAgent-sb_agent_typing % rc-apps deploy --username prajval.admin --password 123456 --url http://localhost:3000
packaging your app... packaged!
deploying your app... !
Error: Deployment error: Invalid App package. Could not find the classFile (SalesforceLiveAgentApp.js) file.
    at Deploy.asyncSubmitData (/usr/local/lib/node_modules/@rocket.chat/apps-cli/lib/commands/deploy.js:100:19)

I tried uploading the dist file directly but still facing the same issue.

@Shailesh351
Copy link
Collaborator Author

@PrajvalRaval which version of server you are running?

I have tested with cherry picking commits form upstream PR.

And also there are some changes going on for removing ts compiler for appa may be that can be the issue.

@PrajvalRaval
Copy link

@PrajvalRaval which version of server you are running?

I have tested with cherry picking commits form upstream PR.

And also there are some changes going on for removing ts compiler for appa may be that can be the issue.

Using this one -> https://github.com/RocketChat/Rocket.Chat/releases/tag/3.8.0-rc.0

@Shailesh351
Copy link
Collaborator Author

@PrajvalRaval For now to test this one you can cherry-pick changes from RocketChat/Rocket.Chat#19228 on our develop_pwa branch.

There is major change in app compilation and packaging process from upstream. We will need to first merge upstream catchup PRs in Apps-Engine and RC Server.
RocketChat/Rocket.Chat#18687
RocketChat/Rocket.Chat.Apps-engine#307
https://github.com/RocketChat/Rocket.Chat.Apps-compiler
We will also need latest version(1.7.1) for Apps-CLI RocketChat/Rocket.Chat.Apps-cli#85 https://github.com/RocketChat/Rocket.Chat.Apps-cli/releases/tag/v1.7.1

@PrajvalRaval
Copy link

@PrajvalRaval For now to test this one you can cherry-pick changes from RocketChat/Rocket.Chat#19228 on our develop_pwa branch.

There is major change in app compilation and packaging process from upstream. We will need to first merge upstream catchup PRs in Apps-Engine and RC Server.
RocketChat/Rocket.Chat#18687
RocketChat/Rocket.Chat.Apps-engine#307
https://github.com/RocketChat/Rocket.Chat.Apps-compiler
We will also need latest version(1.7.1) for Apps-CLI RocketChat/Rocket.Chat.Apps-cli#85 https://github.com/RocketChat/Rocket.Chat.Apps-cli/releases/tag/v1.7.1

I see... These are a lot of changes so let's wait for the releases, I am sure they will be out in a few days, then we can sync them into our repos. Let's keep this PR review pending till that. 👍

@Shailesh351
Copy link
Collaborator Author

I see... These are a lot of changes so let's wait for the releases, I am sure they will be out in a few days, then we can sync them into our repos. Let's keep this PR review pending till that. 👍

Cool!!

@ear-dev
Copy link

ear-dev commented Nov 18, 2020

@Shailesh351 will we be able to merge this one after we merge the new Rocket.Chat catchup to 3.8.0?

@Shailesh351
Copy link
Collaborator Author

Yupp @ear-dev

@ear-dev ear-dev merged commit 7bfee54 into WideChat:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Agent typing Indicators
3 participants