Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read generation options from toml file #5

Open
Robzz opened this issue Sep 4, 2019 · 1 comment · May be fixed by #44
Open

Read generation options from toml file #5

Robzz opened this issue Sep 4, 2019 · 1 comment · May be fixed by #44
Assignees
Labels
S: In Progress Work is ongoing T: enhancement New feature or request
Milestone

Comments

@Robzz
Copy link
Owner

Robzz commented Sep 4, 2019

I'm getting tired with having to specify all the packages I want to document in a workspace. I'd like cargo-docset to read parameters from a toml file (if present/specified), or from the command line otherwise, maybe with the ability to override or add to the parameters from the command line.

I think all that needs to be done is to create the appropriate serializable types (one per command I imagine, and there's only the generate command for now) that we can then deserialize with e.g. serde-toml.

@Robzz Robzz added the T: enhancement New feature or request label Sep 4, 2019
@Robzz Robzz added this to the v0.2.0 milestone Sep 4, 2019
@Robzz Robzz self-assigned this Sep 5, 2019
@Robzz Robzz added the S: In Progress Work is ongoing label Oct 16, 2019
@Robzz Robzz modified the milestones: v0.2.0, v0.3.0 Jun 21, 2020
@Robzz
Copy link
Owner Author

Robzz commented Aug 9, 2022

It seems that Cargo.toml has metadata sections that could be used for this. Something that reads from the workspace.metadata table should probably be fine, for a start. The information is probably not hard to get to with the cargo_metadata crate that we already depend on.

@Robzz Robzz linked a pull request Sep 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: In Progress Work is ongoing T: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant