Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native horizontal scrolling #138

Closed
josephbirkner opened this issue Oct 1, 2019 · 3 comments
Closed

Native horizontal scrolling #138

josephbirkner opened this issue Oct 1, 2019 · 3 comments
Assignees
@nbasargin
Labels
raveboard 🏄‍♂️

Comments

@josephbirkner
Copy link
Collaborator

It would be very useful to be able to scroll horizontally in the UI with natural scrolling gestures, such as two-finger pan or scroll-wheel. This could be achieved by wrapping the SVG area in a div that has overflow-x set to scroll. However, we would need to implement dynamic resizing of the SVG area based on its content.
@josephbirkner josephbirkner changed the title UI: Native horizontal scrolling Native horizontal scrolling Oct 1, 2019
@josephbirkner
Copy link
Collaborator Author

@nbasargin thoughts?

@nbasargin
Copy link
Collaborator

It's on my list. Right now, we move the SVG elements in the graph with transform property which gives nice transitions for free. The size of the graph needs to stay fixed for the automatic resizing. Wrapping the graph into two divs, one with a scrollbar and the other with the correct size set should allow scrolling.

@nbasargin nbasargin self-assigned this Oct 3, 2019
@nbasargin
Copy link
Collaborator

PR's up: #142 🚀

@josephbirkner josephbirkner mentioned this issue Oct 19, 2019
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbasargin nbasargin

Labels
raveboard 🏄‍♂️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nbasargin @josephbirkner