Properly handle unsubcribe for TFClient #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain what was wrong with the old implementation and how this PR improves it? |
|
The old method never properly unsubscribes the processTFArray callback. It must be provided as an argument to the Topic.unsubscribe method to properly be unregistered. This PR saves the callback in a private member and then provides this callback to the unsubscribe method. |
mvollrath
approved these changes
Sep 18, 2020
MatthijsBurgh
pushed a commit
that referenced
this pull request
Jun 20, 2021
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
* Fix whitespace * (actions) add GH actions; update travis * Fix missing semi-colon * Drop unused concat task and related * Add tests * Run tests in CI * (travis) remove travis * (lint) ignore in grunt config * don't use outdated cdn in browser tests * (actions) build needs to be in sync with library * build; add package-lock.json * Remove bower.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.