Fix TypeError: this.ros.ActionClient is not a function #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using the ES6 import statement to load roslib which works fine for most roslib modules, except `TFClient`. That module doesn't properly import it's dependencies but relies on the properties on the ros object. I rewrote it a little bit to make it work for ES6 imports. Should be backwards compatible.
MatthijsBurgh
pushed a commit
that referenced
this pull request
Jun 20, 2021
I'm using the ES6 import statement to load roslib which works fine for most roslib modules, except `TFClient`. That module doesn't properly import it's dependencies but relies on the properties on the ros object. I rewrote it a little bit to make it work for ES6 imports. Should be backwards compatible.
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
…trol with renderOrder. (RobotWebTools#340)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the ES6 import statement to load roslib which works fine for
most roslib modules, except
TFClient. That module doesn't properlyimport it's dependencies but relies on the properties on the ros object.
I rewrote it a little bit to make it work for ES6 imports. Should be
backwards compatible.