Move msg/srv from rosapi and rosbridge_library into separate packages; enable Rolling in CI #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; enable Rolling in CI
This was referenced Oct 11, 2021
amacneil
approved these changes
Oct 14, 2021
jtbandes
added a commit
that referenced
this pull request
Oct 16, 2021
Missed in #665. Who knows why CI passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
The msg and srv interfaces under
rosapiare moving to a new packagerosapi_msgs. The ones fromrosbridge_librarywere used only for testing and are moving to a new packagerosbridge_test_msgs.The intent will be, if possible, to addIt sounds like this may not be possible based on ros2/rosidl_python#141 (comment).rosapi_msgsto the ROS distros, but notrosbridge_test_msgs.Description
Fixes #581. Closes #602.
Due to a change in rosidl_python, the generated python packages containing msg classes were conflicting with the python package these libraries export (ros2/rosidl_python#141). The solution recommended by @clalancette in that thread was to split these definitions into separate packages.