Adaptations to Eloquent [Again] #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adapt rosbridge_suite to ROS2 Eloquent - increase spin period to 1000Hz to allow 1000 messages per second into the websocket - increase parsing speed of sensor_msgs/CompressedImage - add some debug messages - allow interpreting int as float when needed - better handling array.array and numpy arrays - allow bytes and str websocket messages Contributors: @joshwapohlmann @mmatthe
- adapt rosbridge_suite to ROS2 Eloquent - increase spin period to 1000Hz to allow 1000 messages per second into the websocket - increase parsing speed of sensor_msgs/CompressedImage - add some debug messages - allow interpreting int as float when needed - better handling array.array and numpy arrays - allow bytes and str websocket messages
- remove extraneous print statements - remove unused packages - remove whitespace - move message conversion to str into websocket_handler
Adding a dict `shortcut_object_decoders` that contains functions that handles decoding of specific objects quicker than the generic method. remove requirements.txt Co-authored-by: joshwapohlmann <[email protected]>
Co-Authored-by: joshwapohlmann <[email protected]>
Signed-off-by: Travis Prosser <[email protected]>
This was referenced Sep 19, 2020
|
bright side of all of these ROS2 PR's is that the github actions seem to be working 😄 |
Yes! Very happy to see the green checkmarks again. |
mvollrath
approved these changes
Sep 19, 2020
|
Very Happy to see this. 😃😃😃 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension to #493 which fixes some outstanding requests from code review, and adds some extra fixes.