Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth not working properly since Autobahn websocket server #434

Closed
reinzor opened this issue Sep 23, 2019 · 9 comments
Closed

Auth not working properly since Autobahn websocket server #434

reinzor opened this issue Sep 23, 2019 · 9 comments

Comments

@reinzor
Copy link

reinzor commented Sep 23, 2019

Expected Behavior

Authentication should work with multiple clients.

Actual Behavior

When multiple clients set-up an auth connection, at some point the auth service is not called and the client is not authenticated. When running the authenticated websocket server separately, it seems that it hangs and does not respond on any incoming connections.

Steps to Reproduce the Problem

  1. Start websocket server with authentication
  2. Open auth connection with client 1
  3. Open auth connection with client 2
  4. Refresh pages of clients a couple of times

I could only reproduce this when the system is under some load. With a simple set-up, this does not occur.

Specifications

  • ROS Version (MELODIC):
  • OS Version (Ubuntu 18.04 LTS):
  • Rosbridge Version (3b375b23a4bc36cdc0d79fab8914def77951ded4):
  • Twisted Version ([Twisted, version 17.9.0]):
@mvollrath
Copy link
Contributor

@reinzor I can't find documentation about how to run the authenticate service, can you point me at some information so I can try to repro this?

@reinzor
Copy link
Author

reinzor commented Sep 24, 2019

This is indeed not properly documented (maybe we should add some documentation in the rosbridge aswell).

Rosauth package doc: http://wiki.ros.org/rosauth

then call the authenticate method on the roslibjs ROS connection instance:

http://robotwebtools.org/jsdoc/roslibjs/current/Ros.html#authenticate

@reinzor
Copy link
Author

reinzor commented Sep 24, 2019

However, after more testing, it seems to hang only under heavy load so maybe this might be related to #425

@mvollrath
Copy link
Contributor

@reinzor is this still an issue?

@reinzor
Copy link
Author

reinzor commented Jan 6, 2020

Yes, for now I reduced the bandwidth and it seems to work fine but for high loads, authentication seems to fail for some reason. It seems that something is "hanging".

@mvollrath
Copy link
Contributor

I tried to repro this but couldn't get it to auth properly under normal conditions. I'm happy to debug this when there's documentation on how to set it up.

@mvollrath
Copy link
Contributor

You might find this works better with #464

@reinzor
Copy link
Author

reinzor commented Mar 10, 2020

We will try this out! Thanks

@reinzor
Copy link
Author

reinzor commented Jun 12, 2020

Seemed to be coupled to #425 , no longer deserves a separate issue.

@reinzor reinzor closed this as completed Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants