fix: electron

[koonpeng]

Workaround ENAMETOOLONG error when running in electron renderer process.

With this PR in electron electron/electron#24659, rclnodejs is able to run in electron's main process and renderer process with allowRendererProcessReuse set to false.

[coveralls]

Coverage remained the same at 84.384% when pulling f77f294 on fix/electron into 9523d21 on develop.

[koonpeng]

some info about the problem.

electron/chromium changes argv[0] to provide more helpful description in ps, however ros also uses argv[0] to determine the filename for logs. This often causes ros to use a filename that is too long for the system, resulting in ENAMETOOLONG error.

This is a workaround for it that terminates argv[0] on the first " -" occurrence so ros logging can create usable filenames. @minggangw Do you think if we should workaround it in rclnodejs or try to fix it in rcl? rcl is using program_invocation_name which is a glibc extension, I don't know if this affects windows or mac as it uses different ways to get the program name.

[minggangw]

Do you think if we should workaround it in rclnodejs or try to fix it in rcl?

As the usage of Electron is specific to rclnodejs only, I think it's fine to solve it inside rclnodejs itself.

rcl is using program_invocation_name which is a glibc extension

So, how rcl deals with the log file's name on Windows/macOS? What happens if we are running Election with rclnodejs on Windows when logging, will still meet ENAMETOOLONG?

[koonpeng]

https://github.com/chromium/chromium/blob/f18e79d901f56154f80eea1e2218544285e62623/services/service_manager/embedder/set_process_title.cc#L88 It says here that windows and mac doesn't do anything so I believe that this only affects linux.

[minggangw]

I see, so I reckon we will not have this kind of problem on Windows/macOS and this PR looks good now 👍

[minggangw]

Thanks for working on this issue, lgtm and thanks!

[minggangw]

@koonpeng would you please change the status to “Ready for review”, so I can merge this PR.

[koonpeng]

I just updated to status. Thanks!