Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getClock to Node object #592

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Add getClock to Node object #592

merged 2 commits into from
Mar 3, 2020

Conversation

mattrichard
Copy link
Collaborator

@mattrichard mattrichard commented Mar 1, 2020

Adds an internal clock to rclnodejs nodes. In addition this also makes the following changes:

  • Timer handles will now be children of the clock handle. This matches rclpy's implementation.
  • Parameter events will use the node's clock instead of creating a new one each time.
  • Exposes ClockType publicly.

Actions will also require use of the node's clock.

Fix #None

lib/node.js Outdated Show resolved Hide resolved
lib/node.js Show resolved Hide resolved
Copy link
Member

@minggangw minggangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this function LGTM

@minggangw minggangw merged commit e97d67f into RobotWebTools:develop Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants