Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getLogger to Node object #591

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Add getLogger to Node object #591

merged 1 commit into from
Mar 1, 2020

Conversation

mattrichard
Copy link
Collaborator

Adds getLogger function to the Node class. Both rclcpp and rclpy provide a get_logger function on the Node class, but it was missing in rclnodejs.

Actions make use of this, but it's a really a separate feature.

Fix #None

minggangw
minggangw approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@minggangw minggangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this to expose the log interface, LGTM

@minggangw minggangw merged commit d3d5c2f into RobotWebTools:develop Mar 1, 2020
@minggangw minggangw mentioned this pull request Mar 2, 2020
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggangw minggangw minggangw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattrichard @minggangw