You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As @jwnimmer-tri pointed out on Slack, targets underneath //bindings/pydrake/examples presently violate ODR, similar to #8908.
At present, we are getting lucky that we do not encounter the same segfault as #8908, but it may happen shortly. This should be fixed, most ideally by having all examples link to drake_shared_library, or even better, using granular shared libraries (#7294).
If we have chosen to install pydrake libraries with these (and more) example plants, then it follows that we should also be installing the C++ flavor of the libraries as well. The correct solution here is to expand libdrake.so to include these plants, and then we can remove the incorrect cc_deps from the pydrake build rules for them.
The next step to make that happen is to make the library_lint also apply to the examples folders (currently they are all ignored); I'll work on that.
As @jwnimmer-tri pointed out on Slack, targets underneath
//bindings/pydrake/examples
presently violate ODR, similar to #8908.At present, we are getting lucky that we do not encounter the same segfault as #8908, but it may happen shortly. This should be fixed, most ideally by having all examples link to
drake_shared_library
, or even better, using granular shared libraries (#7294).In attempting to reproduce along the lines of #8908, it seems that we are extra lucky in that it does not cause a segfault akin to
bazel test //examples/kuka_iiwa_arm:kuka_simulation_test
when not linking targets directly tolibdrake.so
viacc_binary(..., srcs = ["...:libdrake.so"])
:https://github.com/RobotLocomotion/drake/compare/master...EricCousineau-TRI:issue/8908-repro-wip?expand=1#diff-9454df01e25d57f36c12f3b200dc2988
(EricCousineau-TRI@1067f19)
For this reason, we should maybe consider this a low priority pending resolution of #7294?
The text was updated successfully, but these errors were encountered: