Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bullet external project uses patch, there is no patch on Windows #1787

Closed
billhoffman opened this issue Mar 2, 2016 · 1 comment
Closed

bullet external project uses patch, there is no patch on Windows #1787

billhoffman opened this issue Mar 2, 2016 · 1 comment
Assignees
@billhoffman
Labels
unused team: kitware

Comments

@billhoffman
Copy link
Contributor

Due to a bad check on the windows build this got by. I am going to fix the check and it will break the builds coming after it. @RussTedrake do we need the patches found here: https://github.com/RobotLocomotion/bullet-pod? If so, we should use the copy files method that is save cross platform with cmake. Eigen is doing this:

PATCH_COMMAND cmake -E copy ${PROJECT_SOURCE_DIR}/Translation-patched.h Eigen/src/Geometry/Translation.h && cmake -E copy ${PROJECT_SOURCE_DIR}/AutoDiffScalar-patched.h unsupported/Eigen/src/AutoDiff/AutoDiffScalar.h && cmake -E copy ${PROJECT_SOURCE_DIR}/GeneralBlockPanelKernel-patched.h Eigen/src/Core/products/GeneralBlockPanelKernel.h
@billhoffman billhoffman self-assigned this Mar 2, 2016
@jpieper-tri jpieper-tri mentioned this issue Mar 7, 2016
Merged
@billhoffman
Copy link
Contributor Author

This was resolved by using a github fork of bullet3 instead of patching it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billhoffman billhoffman

Labels
unused team: kitware
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billhoffman