Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self-subclasses #194

Closed
hina-shah opened this issue Jan 10, 2024 · 5 comments
Closed

Remove self-subclasses #194

hina-shah opened this issue Jan 10, 2024 · 5 comments
Labels
AIM 1 bug Something isn't working UI

Comments

@hina-shah
Copy link

To reproduce:
In question builder, try submitting a query "asthma" relates to "asthma". This will create a result table, and one of the rows should be from asthma to asthma. If you click on the row it looks like here in the image:

image
@cbizon
Copy link
Contributor

cbizon commented Apr 14, 2024

I think we should filter out A - subclass-of - A edges somewhere. Logically true; totally useless.

@cbizon cbizon changed the title A graph in answer explorer with a self edge looks weird. Remove self-subclasses Apr 14, 2024
@cbizon cbizon added the AIM 1 label Apr 14, 2024
@EvanDietzMorris
Copy link

Is this something we could apply more generally? Are there any A-->A edges in robokop we care about? The issue is complicated by the fact that this can occur during normalization.

@cbizon
Copy link
Contributor

cbizon commented Apr 16, 2024

I think that there are probably self-interaction or self-regulation edges that we would want to keep

@EvanDietzMorris
Copy link

cool, I think if we want zero A-subclass_of-A edges we can pretty easily apply that in normalization by default, but it should probably be it's own operation that can be specified in the graph spec

@EvanDietzMorris
Copy link

This is implemented in ORION now, subclass loop edges are removed from robokopkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIM 1 bug Something isn't working UI
Projects
None yet
Development

No branches or pull requests

3 participants