Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation of psbts on client side #6

Open
f321x opened this issue Aug 26, 2024 · 0 comments
Open

No validation of psbts on client side #6

f321x opened this issue Aug 26, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@f321x
Copy link
Collaborator

f321x commented Aug 26, 2024

The current client does no detailed validation of the psbts it gets presented to sign. It would be good practice to perform some checks on the transactions before signing it and returning the signature to the coordinator.
The coordinator is trusted anyways, so malicious behaviour is not assumed, but bugs could happen, for example use of a different change address than the one submitted by the client, which could be detected by client side validation.

@f321x f321x added the enhancement New feature or request label Aug 26, 2024
@f321x f321x added this to the v0.1 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant