Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of absolute transaction fees for escrow and payout transactions #16

Open
f321x opened this issue Aug 27, 2024 · 0 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@f321x
Copy link
Collaborator

f321x commented Aug 27, 2024

The current implementation uses absolute transaction fees as the implementation is less complex. This works for testing as the transactions have roughly the same size every time. If there are more inputs to the escrow locking tx this scheme could fail, so a way to dynamically adjust the transaction fees to the size of the transaction and the mempool congestion should be implemented.
Affected function:

Escrow locking tx:
pub async fn create_escrow_psbt(
		&self,
		db: &Arc<CoordinatorDB>,
		taker_psbt_request: &OfferPsbtRequest,
	) -> Result<EscrowPsbt>

Payout tx:
pub async fn assemble_keyspend_payout_psbt(
		&self,
		payout_information: &PayoutData,
	) -> anyhow::Result<String>
@f321x f321x added the enhancement New feature or request label Aug 27, 2024
@f321x f321x added this to the v0.1 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant