Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Add stackTrace getter #93

Merged
merged 6 commits into from
May 16, 2018

Conversation

AmaranthineCodices
Copy link
Contributor

Closes #81. Adds a stackTrace method to Component that returns the current stack trace for the instance. This will return nil when elementTracing is false.

@coveralls
Copy link

coveralls commented May 15, 2018

Coverage Status

Coverage increased (+0.2%) to 90.409% when pulling 0528d1a on AmaranthineCodices:expose-stack-trace into b25a063 on Roblox:master.

@LPGhatguy
Copy link
Contributor

Is there a more descriptive name we can give this? It's the stack trace of where the component's corresponding element was created.

One thing that's fascinating is that this stack trace can change over the lifetime of the component!

@AmaranthineCodices
Copy link
Contributor Author

Yeah, naming is definitely something that can be changed...maybe something like rootElementTraceback or elementTraceback? I'm not super sure about the exact name, but it's important, since there's two or three possible stack traces a component can have >.<

@AmaranthineCodices AmaranthineCodices mentioned this pull request May 16, 2018
2 tasks
@LPGhatguy
Copy link
Contributor

I suspect it should have a verb, like getElementTraceback would be pretty good!

@AmaranthineCodices
Copy link
Contributor Author

Done!

AmaranthineCodices added a commit to AmaranthineCodices/roact that referenced this pull request May 16, 2018
@LPGhatguy
Copy link
Contributor

I keep forgetting this, but can you add an entry to CHANGELOG in the style of the other entries?

@LPGhatguy LPGhatguy self-requested a review May 16, 2018 22:18
Copy link

@SlartibartfastFjords SlartibartfastFjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@LPGhatguy LPGhatguy merged commit f8edb9f into Roblox:master May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants